Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 297703006: reland 'upload SKP renderings that did not match expectations' (Closed)

Created:
6 years, 7 months ago by epoger
Modified:
6 years, 7 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/buildbot.git@master
Visibility:
Public.

Description

reland 'upload SKP renderings that did not match expectations' BUG=skia:1942, skia:2582 Committed: https://skia.googlesource.com/buildbot/+/cb5a4036553fb6de7a6196eac41a00e82eb47a9b

Patch Set 1 : patching in the original CL without modification #

Patch Set 2 : should fix PreRender failure on ChromeOS bots #

Total comments: 1

Patch Set 3 : fix UploadRenderedSKPs failure on other bots #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -84 lines) Patch
M slave/skia_slave_scripts/build_step.py View 2 chunks +12 lines, -1 line 0 comments Download
M slave/skia_slave_scripts/flavor_utils/android_build_step_utils.py View 2 chunks +15 lines, -12 lines 0 comments Download
M slave/skia_slave_scripts/flavor_utils/default_build_step_utils.py View 6 chunks +38 lines, -9 lines 0 comments Download
M slave/skia_slave_scripts/flavor_utils/ssh_build_step_utils.py View 1 chunk +3 lines, -1 line 0 comments Download
M slave/skia_slave_scripts/playback_dirs.py View 5 chunks +41 lines, -11 lines 0 comments Download
M slave/skia_slave_scripts/postrender.py View 1 chunk +16 lines, -3 lines 0 comments Download
M slave/skia_slave_scripts/prerender.py View 1 3 chunks +30 lines, -4 lines 0 comments Download
M slave/skia_slave_scripts/render_skps.py View 1 chunk +58 lines, -29 lines 0 comments Download
M slave/skia_slave_scripts/run_gm.py View 2 chunks +4 lines, -5 lines 0 comments Download
M slave/skia_slave_scripts/upload_rendered_skps.py View 1 2 2 chunks +28 lines, -9 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
epoger
https://codereview.chromium.org/297703006/diff/20001/slave/skia_slave_scripts/prerender.py File slave/skia_slave_scripts/prerender.py (right): https://codereview.chromium.org/297703006/diff/20001/slave/skia_slave_scripts/prerender.py#newcode100 slave/skia_slave_scripts/prerender.py:100: if not os.path.isdir(self.playback_expected_summaries_dir): I think patchset 2 will fix ...
6 years, 7 months ago (2014-05-21 17:10:42 UTC) #1
epoger
Eric- please review diffs between patchset 1 and patchset 3. https://codereview.chromium.org/297703006/diff/40001/slave/skia_slave_scripts/upload_rendered_skps.py File slave/skia_slave_scripts/upload_rendered_skps.py (right): https://codereview.chromium.org/297703006/diff/40001/slave/skia_slave_scripts/upload_rendered_skps.py#newcode29 ...
6 years, 7 months ago (2014-05-21 18:21:15 UTC) #2
epoger
https://codereview.chromium.org/297703006/diff/40001/slave/skia_slave_scripts/upload_rendered_skps.py File slave/skia_slave_scripts/upload_rendered_skps.py (right): https://codereview.chromium.org/297703006/diff/40001/slave/skia_slave_scripts/upload_rendered_skps.py#newcode29 slave/skia_slave_scripts/upload_rendered_skps.py:29: if os.listdir(src_dir): On 2014/05/21 18:21:16, epoger wrote: > Local ...
6 years, 7 months ago (2014-05-21 18:22:45 UTC) #3
borenet
LGTM
6 years, 7 months ago (2014-05-21 18:24:05 UTC) #4
epoger
The CQ bit was checked by epoger@google.com
6 years, 7 months ago (2014-05-21 18:24:21 UTC) #5
epoger
The CQ bit was unchecked by epoger@google.com
6 years, 7 months ago (2014-05-21 18:24:34 UTC) #6
epoger
The CQ bit was checked by epoger@google.com
6 years, 7 months ago (2014-05-21 20:49:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/297703006/40001
6 years, 7 months ago (2014-05-21 20:50:28 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 20:50:37 UTC) #9
Message was sent while issue was closed.
Change committed as cb5a4036553fb6de7a6196eac41a00e82eb47a9b

Powered by Google App Engine
This is Rietveld 408576698