reland 'upload SKP renderings that did not match expectations'

reland 'upload SKP renderings that did not match expectations'

BUG=skia:1942, skia:2582
Committed: https://skia.googlesource.com/buildbot/+/cb5a4036553fb6de7a6196eac41a00e82eb47a9b

[epoger, 2014-05-21 17:10:42]

https://codereview.chromium.org/297703006/diff/20001/slave/skia_slave_scripts...
File slave/skia_slave_scripts/prerender.py (right):

https://codereview.chromium.org/297703006/diff/20001/slave/skia_slave_scripts...
slave/skia_slave_scripts/prerender.py:100: if not
os.path.isdir(self.playback_expected_summaries_dir):
I think patchset 2 will fix the error seen in
http://108.170.220.120:10117/builders/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug...
:

Traceback (most recent call last):
  File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
  File
"/home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-004/buildbot/slave/skia_slave_scripts/build_step.py",
line 315, in run
    self._Run()
  File "../../../../../../slave/skia_slave_scripts/prerender.py", line 118, in
_Run
    self._RunBeforeRenderSKPs()
  File "../../../../../../slave/skia_slave_scripts/prerender.py", line 101, in
_RunBeforeRenderSKPs
    self._device_dirs.PlaybackExpectedSummariesDir())
  File
"/home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-004/buildbot/slave/skia_slave_scripts/flavor_utils/ssh_build_step_utils.py",
line 118, in CopyDirectoryContentsToDevice
    for filename in os.listdir(host_dir):
OSError: [Errno 2] No such file or directory:
'/home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-004/buildbot/third_party/chromium_buildbot/slave/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/build/skia/expectations/skp/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug'

[epoger, 2014-05-21 18:21:15]

Eric- please review diffs between patchset 1 and patchset 3.

https://codereview.chromium.org/297703006/diff/40001/slave/skia_slave_scripts...
File slave/skia_slave_scripts/upload_rendered_skps.py (right):

https://codereview.chromium.org/297703006/diff/40001/slave/skia_slave_scripts...
slave/skia_slave_scripts/upload_rendered_skps.py:29: if os.listdir(src_dir):
Local testing verifies that patchset 3 fixes the UploadRenderedSKPs failure we
saw on various production bots.

[epoger, 2014-05-21 18:22:45]

https://codereview.chromium.org/297703006/diff/40001/slave/skia_slave_scripts...
File slave/skia_slave_scripts/upload_rendered_skps.py (right):

https://codereview.chromium.org/297703006/diff/40001/slave/skia_slave_scripts...
slave/skia_slave_scripts/upload_rendered_skps.py:29: if os.listdir(src_dir):
On 2014/05/21 18:21:16, epoger wrote:
> Local testing verifies that patchset 3 fixes the UploadRenderedSKPs failure we
> saw on various production bots.

example of a production error this would have prevented:

http://108.170.220.120:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Debug/bui...

[borenet, 2014-05-21 18:24:05]

LGTM

[epoger, 2014-05-21 18:24:21]

The CQ bit was checked by epoger@google.com

[epoger, 2014-05-21 18:24:34]

The CQ bit was unchecked by epoger@google.com

[epoger, 2014-05-21 20:49:29]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-05-21 20:50:28]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/epoger@google.com/297703006/40001

[commit-bot: I haz the power, 2014-05-21 20:50:37]

Change committed as cb5a4036553fb6de7a6196eac41a00e82eb47a9b