Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: media/base/media_keys.h

Issue 297703002: Using GURL in place of std::string for destination_url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments, adding checks Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/media_keys.h
diff --git a/media/base/media_keys.h b/media/base/media_keys.h
index 4af35815442224534617bcab63d37f1ad63ec3b1..3166063dd233b989871de7cb03d76129fe843c5d 100644
--- a/media/base/media_keys.h
+++ b/media/base/media_keys.h
@@ -12,6 +12,7 @@
#include "base/callback.h"
#include "base/memory/scoped_ptr.h"
#include "media/base/media_export.h"
+#include "url/gurl.h"
namespace media {
@@ -82,11 +83,9 @@ typedef base::Callback<
void(uint32 session_id, const std::string& web_session_id)>
SessionCreatedCB;
-// TODO(xhwang): Use GURL for |destination_url|. See http://crbug.com/372877
typedef base::Callback<void(uint32 session_id,
const std::vector<uint8>& message,
- const std::string& destination_url)>
- SessionMessageCB;
+ const GURL& destination_url)> SessionMessageCB;
typedef base::Callback<void(uint32 session_id)> SessionReadyCB;

Powered by Google App Engine
This is Rietveld 408576698