media/base/android/media_player_manager.h - Issue 297703002: Using GURL in place of std::string for destination_url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_player_manager.h

Issue 297703002: Using GURL in place of std::string for destination_url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments, adding checks Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/pepper/content_decryptor_delegate.cc ('K') | « media/base/android/media_drm_bridge.cc ('k') | media/base/android/media_source_player_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_player_manager.h

diff --git a/media/base/android/media_player_manager.h b/media/base/android/media_player_manager.h

index 4666fb52bb933f570849ec12e753170da0abc710..c7c996aa67b1e88efa80eaf9093e73053903b52a 100644

--- a/media/base/android/media_player_manager.h

+++ b/media/base/android/media_player_manager.h

@@ -13,6 +13,9 @@

#include "media/base/android/demuxer_stream_player_params.h"

#include "media/base/media_export.h"

#include "media/base/media_keys.h"

+#include "url/gurl.h"

+class GURL;

namespace media {

@@ -91,7 +94,7 @@ class MEDIA_EXPORT MediaPlayerManager {

virtual void OnSessionMessage(int cdm_id,

uint32 session_id,

const std::vector<uint8>& message,

- const std::string& destination_url) = 0;

+ const GURL& destination_url) = 0;

// Called when CDM wants to send a Ready event.

virtual void OnSessionReady(int cdm_id, uint32 session_id) = 0;