content/renderer/media/crypto/proxy_decryptor.cc - Issue 297703002: Using GURL in place of std::string for destination_url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/crypto/proxy_decryptor.cc

Issue 297703002: Using GURL in place of std::string for destination_url (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments, adding checks Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/android/browser_media_player_manager.cc ('K') | « content/renderer/media/crypto/proxy_decryptor.h ('k') | content/renderer/media/webcontentdecryptionmodulesession_impl.h » ('j') | content/renderer/pepper/content_decryptor_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/crypto/proxy_decryptor.cc

diff --git a/content/renderer/media/crypto/proxy_decryptor.cc b/content/renderer/media/crypto/proxy_decryptor.cc

index 95fe49ffc7ee4f3bac4a105568943868ed3cd8a7..079304eb4779320acb8799b8e643ce4920e9b0b4 100644

--- a/content/renderer/media/crypto/proxy_decryptor.cc

+++ b/content/renderer/media/crypto/proxy_decryptor.cc

@@ -223,9 +223,10 @@ void ProxyDecryptor::OnSessionCreated(uint32 session_id,

void ProxyDecryptor::OnSessionMessage(uint32 session_id,

const std::vector<uint8>& message,

- const std::string& destination_url) {

+ const GURL& destination_url) {

// Assumes that OnSessionCreated() has been called before this.

- key_message_cb_.Run(LookupWebSessionId(session_id), message, destination_url);

+ key_message_cb_.Run(

+ LookupWebSessionId(session_id), message, destination_url.spec());

}

void ProxyDecryptor::OnSessionReady(uint32 session_id) {