Using GURL in place of std::string for destination_url

media/base/android/media_drm_bridge.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/android/media_drm_bridge.h"
 
 #include <algorithm>
 
 #include "base/android/build_info.h"
 #include "base/android/jni_array.h"
@@ skipping 415 matching lines @@
 }
 
 void MediaDrmBridge::OnSessionMessage(JNIEnv* env,
                                       jobject j_media_drm,
                                       jint j_session_id,
                                       jbyteArray j_message,
                                       jstring j_destination_url) {
   uint32 session_id = j_session_id;
   std::vector<uint8> message;
   JavaByteArrayToByteVector(env, j_message, &message);
-  std::string destination_url = ConvertJavaStringToUTF8(env, j_destination_url);
-  session_message_cb_.Run(session_id, message, destination_url);
+  GURL destination_gurl = GURL(ConvertJavaStringToUTF8(env, j_destination_url));

[xhwang, 2014/05/21 16:59:01]

Can you move the GURL verification in
BrowserMediaPlayerManager::OnSessionMessage() here? It seems better to do the
checking when we convert it from string to GURL.

+  session_message_cb_.Run(session_id, message, destination_gurl);
 }
 
 void MediaDrmBridge::OnSessionReady(JNIEnv* env,
                                     jobject j_media_drm,
                                     jint j_session_id) {
   uint32 session_id = j_session_id;
   session_ready_cb_.Run(session_id);
 }
 
 void MediaDrmBridge::OnSessionClosed(JNIEnv* env,
@@ skipping 35 matching lines @@
   JNIEnv* env = AttachCurrentThread();
   Java_MediaDrmBridge_resetDeviceCredentials(env, j_media_drm_.obj());
 }
 
 void MediaDrmBridge::OnResetDeviceCredentialsCompleted(
     JNIEnv* env, jobject, bool success) {
   base::ResetAndReturn(&reset_credentials_cb_).Run(success);
 }
 
 }  // namespace media