Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2608)

Unified Diff: pkg/front_end/lib/src/base/processed_options.dart

Issue 2977013002: Report messages instead of just printing. (Closed)
Patch Set: Update expectations. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/base/processed_options.dart
diff --git a/pkg/front_end/lib/src/base/processed_options.dart b/pkg/front_end/lib/src/base/processed_options.dart
index a762812b7286264841246efb9153006f33f8a9dd..189cc2aefbc6013a9bbfb49fcebe9ee7c4d81eba 100644
--- a/pkg/front_end/lib/src/base/processed_options.dart
+++ b/pkg/front_end/lib/src/base/processed_options.dart
@@ -113,11 +113,6 @@ class ProcessedOptions {
return _raw.byteStore;
}
- // TODO(sigmund,ahe): delete in favor of reportMessage.
- void deprecated_reportError(String error) {
- _raw.onError(new _StringMessage(error));
- }
-
void reportMessage(LocatedMessage message) {
_raw.onError(new _CompilationMessage(message));
}
@@ -374,14 +369,3 @@ class _CompilationMessage implements CompilationError {
String toString() => message;
}
-
-/// Wraps an error message as a [CompilationError] API.
-class _StringMessage implements CompilationError {
- final String message;
- String get tip => null;
- SourceSpan get span => null;
-
- _StringMessage(this.message);
-
- String toString() => message;
-}
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/command_line_reporting.dart » ('j') | runtime/vm/isolate_reload_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698