pkg/front_end/lib/src/fasta/severity.dart - Issue 2977013002: Report messages instead of just printing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/front_end/lib/src/fasta/severity.dart

Issue 2977013002: Report messages instead of just printing. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 library fasta.severity;

	6

	7 enum Severity {

	8 error,

	9 internalProblem,
	Siggi Cherem (dart-lang) 2017/07/13 21:05:56 interesting, I had not considered treating interna interesting, I had not considered treating internalProblem as a severity, but as a kind of message. I'm not opposed to it though, just hadn't thought of it this way. Next steps: expose this in the public API as well. ahe 2017/07/14 10:01:07 Acknowledged. Show quoted text On 2017/07/13 21:05:56, Siggi Cherem (dart-lang) wrote: > interesting, I had not considered treating internalProblem as a severity, but as > a kind of message. > > I'm not opposed to it though, just hadn't thought of it this way. > > Next steps: expose this in the public API as well. Acknowledged.
	10 nit,

	11 warning,

	12 }

OLD	NEW