Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2976973002: dart2ks-kernel: constant types and constant lists with type parameters (Closed)

Created:
3 years, 5 months ago by sra1
Modified:
3 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2ks-kernel: constant types and constant lists with type parameters This CL is relative to https://codereview.chromium.org/2981543002/ BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/ac6d0b524e3772954c4d5a313b0c31e711618507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 5 chunks +8 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
3 years, 5 months ago (2017-07-13 00:17:21 UTC) #3
Johnni Winther
lgtm
3 years, 5 months ago (2017-07-13 09:00:05 UTC) #4
sra1
3 years, 5 months ago (2017-07-13 17:08:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac6d0b524e3772954c4d5a313b0c31e711618507 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698