Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2976903002: [observatory] Default sort allocation profiles by size instead of name. (Closed)

Created:
3 years, 5 months ago by rmacnak
Modified:
3 years, 4 months ago
Reviewers:
cbernaschina
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[observatory] Default sort allocation profiles by size instead of name. Remove extra asterisk from optimized code references. R=cbernaschina@google.com Committed: https://github.com/dart-lang/sdk/commit/87aaa8bdb3cc36620992c06781194191d58fb18b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M runtime/observatory/lib/src/elements/allocation_profile.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_ref.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
3 years, 5 months ago (2017-07-12 19:55:14 UTC) #3
cbernaschina
On 2017/07/12 19:55:14, rmacnak wrote: LGTM
3 years, 4 months ago (2017-07-27 17:54:41 UTC) #4
rmacnak
3 years, 4 months ago (2017-07-27 22:16:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
87aaa8bdb3cc36620992c06781194191d58fb18b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698