Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 297683012: Mojo: Add a RawChannel::EnqueueMessage() that can be overridden by subclasses. (Closed)

Created:
6 years, 7 months ago by viettrungluu
Modified:
6 years, 7 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Add a RawChannel::EnqueueMessage() that can be overridden by subclasses. This mostly adds a TODO for POSIX. (We want to actually send "real" messages with FDs attached, which means that we have to "split" any message with too many FDs into multiple messages.) R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272471

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -23 lines) Patch
M mojo/system/raw_channel.h View 2 chunks +19 lines, -11 lines 0 comments Download
M mojo/system/raw_channel.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M mojo/system/raw_channel_posix.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
6 years, 7 months ago (2014-05-22 22:22:29 UTC) #1
yzshen1
lgtm
6 years, 7 months ago (2014-05-22 23:23:55 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-22 23:24:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/297683012/1
6 years, 7 months ago (2014-05-22 23:24:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 02:24:42 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 10:40:32 UTC) #6
Message was sent while issue was closed.
Change committed as 272471

Powered by Google App Engine
This is Rietveld 408576698