Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 297683002: Remove DevTools instrumentation of Blink promises. (Closed)

Created:
6 years, 7 months ago by aandrey
Modified:
6 years, 7 months ago
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, Inactive, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove DevTools instrumentation of Blink promises. This is a dead code now since we moved from Blink promises to V8 ones. BUG=348919, 352597 TBR=yhirano@chromium.org, amikhaylova@google.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174378

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -397 lines) Patch
M Source/bindings/bindings.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D Source/bindings/v8/ScriptObjectTraits.h View 1 chunk +0 lines, -54 lines 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.cpp View 8 chunks +0 lines, -35 lines 0 comments Download
M Source/core/core.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.cpp View 1 3 chunks +0 lines, -27 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 4 chunks +0 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 3 chunks +0 lines, -43 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +0 lines, -28 lines 0 comments Download
D Source/core/inspector/InspectorPromiseInstrumentation.h View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/inspector/PromiseTracker.h View 1 chunk +0 lines, -87 lines 0 comments Download
D Source/core/inspector/PromiseTracker.cpp View 1 chunk +0 lines, -102 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
aandrey
6 years, 7 months ago (2014-05-20 09:39:01 UTC) #1
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 7 months ago (2014-05-20 09:39:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/297683002/1
6 years, 7 months ago (2014-05-20 09:39:26 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 10:53:24 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 11:24:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/6606)
6 years, 7 months ago (2014-05-20 11:24:14 UTC) #6
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 7 months ago (2014-05-20 11:53:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/297683002/1
6 years, 7 months ago (2014-05-20 11:53:18 UTC) #8
aandrey
The CQ bit was unchecked by aandrey@chromium.org
6 years, 7 months ago (2014-05-20 11:53:20 UTC) #9
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 7 months ago (2014-05-20 11:54:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/297683002/20001
6 years, 7 months ago (2014-05-20 11:55:06 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 13:10:29 UTC) #12
Message was sent while issue was closed. 
Change committed as 174378

Powered by Google App Engine
This is Rietveld 408576698