Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: runtime/vm/runtime_entry_ia32.cc

Issue 2976723003: Eliminate dependencies on assemblers and code stubs in precompiled runtime. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/runtime_entry.h" 8 #include "vm/runtime_entry.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
11 #include "vm/stub_code.h" 11 #include "vm/stub_code.h"
12 12
13 namespace dart { 13 namespace dart {
14 14
15 #define __ assembler-> 15 #define __ assembler->
16 16
17 17
18 uword RuntimeEntry::GetEntryPoint() const { 18 uword RuntimeEntry::GetEntryPoint() const {
19 return reinterpret_cast<uword>(function()); 19 return reinterpret_cast<uword>(function());
20 } 20 }
21 21
22 22
23 #if !defined(DART_PRECOMPILED_RUNTIME)
23 // Generate code to call into the stub which will call the runtime 24 // Generate code to call into the stub which will call the runtime
24 // function. Input for the stub is as follows: 25 // function. Input for the stub is as follows:
25 // For regular runtime calls - 26 // For regular runtime calls -
26 // ESP : points to the arguments and return value array. 27 // ESP : points to the arguments and return value array.
27 // ECX : address of the runtime function to call. 28 // ECX : address of the runtime function to call.
28 // EDX : number of arguments to the call as Smi. 29 // EDX : number of arguments to the call as Smi.
29 // For leaf calls the caller is responsible to setup the arguments 30 // For leaf calls the caller is responsible to setup the arguments
30 // and look for return values based on the C calling convention. 31 // and look for return values based on the C calling convention.
31 void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const { 32 void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const {
32 if (is_leaf()) { 33 if (is_leaf()) {
33 ASSERT(argument_count == this->argument_count()); 34 ASSERT(argument_count == this->argument_count());
34 ExternalLabel label(GetEntryPoint()); 35 ExternalLabel label(GetEntryPoint());
35 __ call(&label); 36 __ call(&label);
36 } else { 37 } else {
37 // Argument count is not checked here, but in the runtime entry for a more 38 // Argument count is not checked here, but in the runtime entry for a more
38 // informative error message. 39 // informative error message.
39 __ movl(ECX, Immediate(GetEntryPoint())); 40 __ movl(ECX, Immediate(GetEntryPoint()));
40 __ movl(EDX, Immediate(argument_count)); 41 __ movl(EDX, Immediate(argument_count));
41 __ CallToRuntime(); 42 __ CallToRuntime();
42 } 43 }
43 } 44 }
45 #endif // !defined(DART_PRECOMPILED_RUNTIME)
44 46
45 } // namespace dart 47 } // namespace dart
46 48
47 #endif // defined TARGET_ARCH_IA32 49 #endif // defined TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698