Eliminate dependencies on assemblers and code stubs in precompiled runtime.

Eliminate dependencies on assemblers and code stubs in precompiled runtime.

Guard all excluded code behind conditional compilation.

Removed precompiled runtime flag. Only preprocessor flag remains.

BUG= https://github.com/dart-lang/sdk/issues/30045
R=rmacnak@google.com, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/46c53882ccf6efdc19d7607c316790febc136b95

[Aske Simon Christensen, 2017-07-11 13:28:06]

Description was changed from

==========
Eliminate dependencies on assemblers and code stubs in precompiled runtime.
Guard all excluded code behind conditional compilation.

BUG=
==========

to

==========
Eliminate dependencies on assemblers and code stubs in precompiled runtime.

Guard all excluded code behind conditional compilation.

BUG= https://github.com/dart-lang/sdk/issues/30045
==========

[Aske Simon Christensen, 2017-07-11 13:28:07]

askesc@google.com changed reviewers:
+ rmacnak@google.com, vegorov@google.com, zra@google.com

[Aske Simon Christensen, 2017-07-11 13:31:34]

Regarding the ProgramVisitor that rmacnak mentioned in the previous CL:
https://codereview.chromium.org/2960413002/

This is used by the ClassFinalizer, which is used in several places. If there is
a false dependency here, it is quite well entangled.

[zra, 2017-07-11 20:25:09]

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/assembler.cc
File runtime/vm/assembler.cc (right):

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/assembler.cc#new...
runtime/vm/assembler.cc:14: #if !defined(DART_PRECOMPILED_RUNTIME)
Should this go above the includes? Here and in other files as well.

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/ast.cc
File runtime/vm/ast.cc (right):

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/ast.cc#newcode5
runtime/vm/ast.cc:5: #if !defined(DART_PRECOMPILED_RUNTIME)
like here.

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:1957: if (code->is_optimized() &&
!FLAG_precompiled_runtime) {
Do you still need to check FLAG_precompiled_runtime?

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2077: ASSERT(!FLAG_precompiled_runtime);
Is this still needed?

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:14484: #if !defined(PRODUCT) &&
!defined(DART_PRECOMPILED_RUNTIME)
Should this be ||?

[Aske Simon Christensen, 2017-07-12 18:51:34]

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/assembler.cc
File runtime/vm/assembler.cc (right):

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/assembler.cc#new...
runtime/vm/assembler.cc:14: #if !defined(DART_PRECOMPILED_RUNTIME)
On 2017/07/11 20:25:08, zra wrote:
> Should this go above the includes? Here and in other files as well.

Certainly. Done.

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:1957: if (code->is_optimized() &&
!FLAG_precompiled_runtime) {
On 2017/07/11 20:25:08, zra wrote:
> Do you still need to check FLAG_precompiled_runtime?

The runtime flag is presumably there to make the full VM behave as a
precompiled-only build. But this does not work anyway (there are many, many
places where only the compile-time flag is checked), so I removed the runtime
flag completely.

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2976723003/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:14484: #if !defined(PRODUCT) &&
!defined(DART_PRECOMPILED_RUNTIME)
On 2017/07/11 20:25:08, zra wrote:
> Should this be ||?

Disassembly is only supported if it is neither a product build, nor a
precompiled one. I would say this one is correct. With || it would try to
disassemble in precompiled debug/release builds, which would not work, since the
disassembler is absent from all precompiled builds.

[Aske Simon Christensen, 2017-07-12 18:53:09]

Description was changed from

==========
Eliminate dependencies on assemblers and code stubs in precompiled runtime.

Guard all excluded code behind conditional compilation.

BUG= https://github.com/dart-lang/sdk/issues/30045
==========

to

==========
Eliminate dependencies on assemblers and code stubs in precompiled runtime.

Guard all excluded code behind conditional compilation.

Removed precompiled runtime flag. Only preprocessor flag remains.

BUG= https://github.com/dart-lang/sdk/issues/30045
==========

[zra, 2017-07-18 15:09:19]

lgtm, but since this is a big change, someone else should also take a look.

[rmacnak, 2017-08-07 22:31:03]

lgtm

[Aske Simon Christensen, 2017-08-09 20:21:59]

Description was changed from

==========
Eliminate dependencies on assemblers and code stubs in precompiled runtime.

Guard all excluded code behind conditional compilation.

Removed precompiled runtime flag. Only preprocessor flag remains.

BUG= https://github.com/dart-lang/sdk/issues/30045
==========

to

==========
Eliminate dependencies on assemblers and code stubs in precompiled runtime.

Guard all excluded code behind conditional compilation.

Removed precompiled runtime flag. Only preprocessor flag remains.

BUG= https://github.com/dart-lang/sdk/issues/30045
R=rmacnak@google.com, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/46c53882ccf6efdc19d7607c316790febc136b95
==========

[Aske Simon Christensen, 2017-08-09 20:22:01]

Committed patchset #2 (id:20001) manually as
46c53882ccf6efdc19d7607c316790febc136b95 (presubmit successful).