Issue 2976683002: Refactor creating AnalysisOptionsImpl and declared variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2976683002: Refactor creating AnalysisOptionsImpl and declared variables. (Closed)

Created:
3 years, 5 months ago by scheglov

Modified:
3 years, 5 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Refactor creating AnalysisOptionsImpl and declared variables. We need to separate declared variables from AnalysisContext because we're going to replace AnalysisContext with AnalysisDriver. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0827191d87bd4e2ec7f63f248130c4b3d236e4b6

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -21 lines)			Patch
	M	pkg/analyzer_cli/lib/src/build_mode.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	pkg/analyzer_cli/lib/src/driver.dart	View		3 chunks	+10 lines, -20 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as 0827191d87bd4e2ec7f63f248130c4b3d236e4b6 (presubmit successful).

3 years, 5 months ago (2017-07-11 18:29:44 UTC) #4

Message was sent while issue was closed.

lgtm