Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 297663008: Increase external allocation limit. (Closed)

Created:
6 years, 7 months ago by Hannes Payer (out of office)
Modified:
6 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Increase external allocation limit. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21411

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/heap.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
LGTM. https://codereview.chromium.org/297663008/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/297663008/diff/1/src/heap.cc#newcode5055 src/heap.cc:5055: // to avoid that resource-constrained embedders run out ...
6 years, 7 months ago (2014-05-21 12:40:59 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/297663008/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/297663008/diff/1/src/heap.cc#newcode5055 src/heap.cc:5055: // to avoid that resource-constrained embedders run out of ...
6 years, 7 months ago (2014-05-21 12:42:56 UTC) #2
Hannes Payer (out of office)
6 years, 7 months ago (2014-05-21 12:43:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698