CapsLock indicator is shown in password field when CapsLock is on.

CapsLock indicator is shown in password field when CapsLock is on.

TEST=manually on login/lock/user adding screens.
BUG=361861
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272176

[dzhioev (left Google), 2014-05-20 14:57:41]

Hi, please review

[ygorshenin1, 2014-05-20 16:37:57]

lgtm

https://codereview.chromium.org/297663004/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/297663004/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:1809:
CallJS("login.AccountPickerScreen.setCapsLockState", caps_lock_enabled_);
nit: could you please add to the Initialize() method call of
login.AccountPickerScreen.setCapsLockState()?

[dzhioev (left Google), 2014-05-20 16:53:10]

https://codereview.chromium.org/297663004/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/297663004/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:1809:
CallJS("login.AccountPickerScreen.setCapsLockState", caps_lock_enabled_);
On 2014/05/20 16:37:57, ygorshenin1 wrote:
> nit: could you please add to the Initialize() method call of
> login.AccountPickerScreen.setCapsLockState()?

We reset Caps Lock state in ShowImpl.

[dzhioev (left Google), 2014-05-20 16:53:14]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-05-20 16:54:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/297663004/1

[commit-bot: I haz the power, 2014-05-20 19:14:41]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-20 19:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 19:23:25]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[dzhioev (left Google), 2014-05-21 13:55:14]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-05-21 19:56:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/297663004/20001

[commit-bot: I haz the power, 2014-05-22 09:04:01]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 09:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 09:07:23]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[dzhioev (left Google), 2014-05-22 11:07:10]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-05-22 11:08:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/297663004/20001

[commit-bot: I haz the power, 2014-05-22 11:11:33]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 11:15:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 11:15:37]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[dzhioev (left Google), 2014-05-22 12:13:27]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-05-22 12:14:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/297663004/20001

[commit-bot: I haz the power, 2014-05-22 12:18:06]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 12:19:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 12:19:50]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[dzhioev (left Google), 2014-05-22 13:30:09]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-05-22 13:31:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/297663004/20001

[commit-bot: I haz the power, 2014-05-22 13:34:57]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 13:36:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 13:36:50]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[dzhioev (left Google), 2014-05-22 14:04:37]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-05-22 14:06:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/297663004/20001

[commit-bot: I haz the power, 2014-05-22 14:55:06]

Change committed as 272176