Fix hot reload test

Fix hot reload test

The test is currently skipped because of some flaky issue (issue #29819). I
noticed the test got broken while it's been disabled. This makes the test be in
working condition, even though it can't be enabled until we fix the underlying
flakiness in the VM.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/2b8ced213277d9348f779d6bbacbf7575c092a97

[Siggi Cherem (dart-lang), 2017-07-07 23:00:35]

Patchset #1 (id:1) has been deleted

[ahe, 2017-07-10 13:59:35]

lgtm

https://codereview.chromium.org/2976553002/diff/20001/pkg/front_end/test/src/...
File pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart (right):

https://codereview.chromium.org/2976553002/diff/20001/pkg/front_end/test/src/...
pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart:220: // start and
start the program via observatory instead.
Let's to that proactively.

[Siggi Cherem (dart-lang), 2017-07-10 19:30:58]

Patchset #2 (id:40001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-10 19:31:11]

PTAL

https://codereview.chromium.org/2976553002/diff/20001/pkg/front_end/test/src/...
File pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart (right):

https://codereview.chromium.org/2976553002/diff/20001/pkg/front_end/test/src/...
pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart:220: // start and
start the program via observatory instead.
On 2017/07/10 13:59:35, ahe wrote:
> Let's to that proactively.

Done.

[ahe, 2017-07-10 19:45:51]

lgtm

[Siggi Cherem (dart-lang), 2017-07-10 19:52:34]

Description was changed from

==========
Fix hot reload test

The test is currently skipped because of some flaky issue (issue #29819). I
noticed the test got broken while it's been disabled. This makes the test be in
working condition, even though it can't be enabled until we fix the underlying
flakiness in the VM.

R=ahe@google.com
==========

to

==========
Fix hot reload test

The test is currently skipped because of some flaky issue (issue #29819). I
noticed the test got broken while it's been disabled. This makes the test be in
working condition, even though it can't be enabled until we fix the underlying
flakiness in the VM.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2b8ced213277d9348f779d6bbacbf7575c092a97
==========

[Siggi Cherem (dart-lang), 2017-07-10 19:52:36]

Committed patchset #2 (id:60001) manually as
2b8ced213277d9348f779d6bbacbf7575c092a97 (presubmit successful).