Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2976543002: Reapply "Tweak public APIs and use them in patch_sdk, dart2js, and kernel-service."" (Closed)

Created:
3 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 5 months ago
Reviewers:
Paul Berry, ahe
CC:
reviews_dartlang.org, turnidge, rmacnak, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Tweak public APIs and use them in patch_sdk, dart2js, and kernel-service."" Original CL had a bug that wasn't visible unless you delete your out/ReleaseX64/patched_sdk folder. Patchset #1 is the original CL, patchset #2 shows the fix. This reverts commit 4aadfe09df6c2cff33b2850cbfc42c9806ed31b1. BUG= Committed: https://github.com/dart-lang/sdk/commit/b71bd543a98c903117045304d2175f02b5714c9a

Patch Set 1 : original CL #

Patch Set 2 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1965 lines, -1301 lines) Patch
A pkg/compiler/lib/src/kernel/dart2js_target.dart View 1 chunk +92 lines, -0 lines 0 comments Download
D pkg/compiler/lib/src/kernel/fasta_support.dart View 1 chunk +0 lines, -201 lines 0 comments Download
M pkg/compiler/tool/generate_kernel.dart View 1 chunk +46 lines, -24 lines 0 comments Download
M pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/compiler_options.dart View 4 chunks +103 lines, -56 lines 0 comments Download
A pkg/front_end/lib/front_end.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/front_end/lib/kernel_generator.dart View 3 chunks +32 lines, -135 lines 0 comments Download
M pkg/front_end/lib/src/base/processed_options.dart View 8 chunks +208 lines, -42 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/compile_platform.dart View 2 chunks +27 lines, -34 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta.dart View 5 chunks +8 lines, -79 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 4 chunks +8 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 6 chunks +5 lines, -86 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/utils.dart View 2 chunks +24 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/loader.dart View 1 chunk +3 lines, -0 lines 0 comments Download
D pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart View 1 chunk +0 lines, -56 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/lib/src/fasta/parser/native_support.dart View 1 chunk +86 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 5 chunks +10 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 5 chunks +11 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 2 chunks +1 line, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/target_implementation.dart View 2 chunks +0 lines, -25 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/kernel_chain.dart View 2 chunks +39 lines, -1 line 0 comments Download
D pkg/front_end/lib/src/fasta/vm.dart View 1 chunk +0 lines, -165 lines 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 4 chunks +3 lines, -19 lines 0 comments Download
A pkg/front_end/lib/src/kernel_generator_impl.dart View 1 chunk +171 lines, -0 lines 0 comments Download
D pkg/front_end/lib/src/simple_error.dart View 1 chunk +0 lines, -11 lines 0 comments Download
A pkg/front_end/lib/src/testing/compiler_common.dart View 1 chunk +123 lines, -0 lines 0 comments Download
M pkg/front_end/lib/summary_generator.dart View 2 chunks +18 lines, -7 lines 0 comments Download
M pkg/front_end/test/fasta/shaker_test.dart View 5 chunks +12 lines, -30 lines 0 comments Download
M pkg/front_end/test/fasta/testing/suite.dart View 3 chunks +6 lines, -9 lines 0 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 2 chunks +3 lines, -6 lines 0 comments Download
A pkg/front_end/test/kernel_generator_test.dart View 1 chunk +210 lines, -0 lines 0 comments Download
M pkg/front_end/test/src/base/processed_options_test.dart View 4 chunks +111 lines, -2 lines 0 comments Download
M pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 4 chunks +7 lines, -10 lines 0 comments Download
A pkg/front_end/test/summary_generator_test.dart View 1 chunk +152 lines, -0 lines 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 7 chunks +23 lines, -36 lines 0 comments Download
M pkg/front_end/tool/perf.dart View 3 chunks +2 lines, -6 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 4 chunks +32 lines, -9 lines 0 comments Download
M pkg/kernel/lib/binary/limited_ast_to_binary.dart View 2 chunks +24 lines, -1 line 0 comments Download
M pkg/kernel/lib/target/targets.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M pkg/kernel/lib/target/vm.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/kernel/test/closures/suite.dart View 4 chunks +13 lines, -73 lines 0 comments Download
M pkg/kernel/test/interpreter/suite.dart View 1 chunk +7 lines, -72 lines 0 comments Download
M pkg/pkg.status View 1 chunk +2 lines, -0 lines 0 comments Download
D runtime/bin/vmservice_sdk/lib/libraries.json View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/dill_loader_test.dart View 3 chunks +21 lines, -17 lines 0 comments Download
M tools/patch_sdk.dart View 1 4 chunks +104 lines, -45 lines 1 comment Download
M utils/kernel-service/kernel-service.dart View 3 chunks +162 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
TBR https://codereview.chromium.org/2976543002/diff/20001/tools/patch_sdk.dart File tools/patch_sdk.dart (right): https://codereview.chromium.org/2976543002/diff/20001/tools/patch_sdk.dart#newcode148 tools/patch_sdk.dart:148: '_vmservice': dartDir.resolve('sdk/lib/vmservice/vmservice.dart'), this file used to be copied ...
3 years, 5 months ago (2017-07-07 22:31:39 UTC) #2
Siggi Cherem (dart-lang)
Committed patchset #2 (id:20001) manually as b71bd543a98c903117045304d2175f02b5714c9a (presubmit successful).
3 years, 5 months ago (2017-07-07 22:32:32 UTC) #4
Paul Berry
3 years, 5 months ago (2017-07-10 15:27:44 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698