Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2976493002: Convert driver_test.dart to reflective tests. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Convert driver_test.dart to reflective tests. It was hard to keep track of defined tests, and to run individual tests. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/73ec7f0a79956d0744823351a2b28477f4b312bd

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+539 lines, -650 lines) Patch
M pkg/analyzer_cli/test/driver_test.dart View 2 chunks +539 lines, -650 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 5 months ago (2017-07-07 16:12:02 UTC) #1
Brian Wilkerson
Assuming the tests didn't change, lgmt. https://codereview.chromium.org/2976493002/diff/1/pkg/analyzer_cli/test/driver_test.dart File pkg/analyzer_cli/test/driver_test.dart (left): https://codereview.chromium.org/2976493002/diff/1/pkg/analyzer_cli/test/driver_test.dart#oldcode71 pkg/analyzer_cli/test/driver_test.dart:71: //TODO(pq): fix to ...
3 years, 5 months ago (2017-07-07 16:25:30 UTC) #2
scheglov
https://codereview.chromium.org/2976493002/diff/1/pkg/analyzer_cli/test/driver_test.dart File pkg/analyzer_cli/test/driver_test.dart (left): https://codereview.chromium.org/2976493002/diff/1/pkg/analyzer_cli/test/driver_test.dart#oldcode71 pkg/analyzer_cli/test/driver_test.dart:71: //TODO(pq): fix to be bot-friendly (sdk#25258). On 2017/07/07 16:25:30, ...
3 years, 5 months ago (2017-07-07 16:37:53 UTC) #3
scheglov
3 years, 5 months ago (2017-07-07 16:38:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
73ec7f0a79956d0744823351a2b28477f4b312bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698