Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2976483002: Further cleanup of element use in type_graph_nodes (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -28 lines) Patch
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 9 chunks +24 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_system.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/container_type_mask.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/dictionary_type_mask.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/map_type_mask.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-07 15:57:56 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2976483002/diff/1/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right): https://codereview.chromium.org/2976483002/diff/1/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart#newcode406 pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:406: //assert(node is ast.Node || node is Element); undo? ...
3 years, 5 months ago (2017-07-07 19:29:05 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 3bd55a50242aabb839e218fd5bdd7695d2900ec2 (presubmit successful).
3 years, 5 months ago (2017-07-10 11:05:15 UTC) #5
Johnni Winther
3 years, 5 months ago (2017-07-10 11:07:30 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2976483002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right):

https://codereview.chromium.org/2976483002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:406: //assert(node is
ast.Node || node is Element);
On 2017/07/07 19:29:04, Siggi Cherem (dart-lang) wrote:
> undo? delete?

Done.

Powered by Google App Engine
This is Rietveld 408576698