Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1892)

Unified Diff: chrome/browser/metrics/chrome_metrics_services_manager_client.cc

Issue 2976453002: Disable UKM on Android (Closed)
Patch Set: Fix name Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/chrome_metrics_services_manager_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_services_manager_client.cc b/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
index 83594d471f40d66c0401f464d54668574ef125eb..d451a34d11bc00412e40a1020eb54359b313da92 100644
--- a/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
@@ -10,11 +10,13 @@
#include "base/memory/ptr_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/task_scheduler/post_task.h"
+#include "build/build_config.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
#include "chrome/browser/metrics/chrome_metrics_service_client.h"
#include "chrome/browser/metrics/variations/chrome_variations_service_client.h"
#include "chrome/browser/metrics/variations/ui_string_overrider_factory.h"
+#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_otr_state.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/installer/util/google_update_settings.h"
@@ -288,5 +290,15 @@ bool ChromeMetricsServicesManagerClient::IsMetricsReportingForceEnabled() {
}
bool ChromeMetricsServicesManagerClient::IsIncognitoSessionActive() {
- return chrome::IsIncognitoSessionActive();
+#if defined(OS_ANDROID)
+ // TODO(crbug/739971) On Android, we don't get notifications from TabModel
+ // when incognito tabs are opened, so this won't get re-evaluated reliably
+ // yet. Assume there always an incognito tab open, which will keep UKM
+ // disabled.
+ return true;
+#else
+ // Depending directly on BrowserList, since that is the implementation
+ // that we get correct notifications for.
+ return BrowserList::IsIncognitoSessionActive();
+#endif
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698