Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2976403002: Update status files for kernel tests (Closed)

Created:
3 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 5 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status files for kernel tests Now kernel-service sends an "error" status whenever there are compile time errors, so many of these tests that were not executed at runtime are now correctly being reported by the VM as compile time errors. This was only possible now that we are plumbing all error messages through a single API, we can later evaluate whether it makes sense to recover on some of these errors and how to deal better with recovery Committed: https://github.com/dart-lang/sdk/commit/9bbe761f4b189a438c94e5eae2783994836ccd45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M tests/co19/co19-kernel.status View 2 chunks +0 lines, -12 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (4 generated)
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-19 03:29:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9bbe761f4b189a438c94e5eae2783994836ccd45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698