Delete old tests that aren't used and/or useful any more.

Delete old tests that aren't used and/or useful any more.

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/1d8c3af663e702332fc6e813eb8bc2d644d51d78

[Bob Nystrom, 2017-07-17 20:03:45]

rnystrom@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-07-17 21:33:49]

lgtm

https://codereview.chromium.org/2976313002/diff/1/tests/utils/recursive_impor...
File tests/utils/recursive_import_test.dart (left):

https://codereview.chromium.org/2976313002/diff/1/tests/utils/recursive_impor...
tests/utils/recursive_import_test.dart:19: main() {
recursive import seems like it would be useful to test, though I don't know why
it's in "utils"...

[Bob Nystrom, 2017-07-17 21:53:49]

https://codereview.chromium.org/2976313002/diff/1/tests/utils/recursive_impor...
File tests/utils/recursive_import_test.dart (left):

https://codereview.chromium.org/2976313002/diff/1/tests/utils/recursive_impor...
tests/utils/recursive_import_test.dart:19: main() {
On 2017/07/17 21:33:49, Emily Fortuna wrote:
> recursive import seems like it would be useful to test, though I don't know
why
> it's in "utils"...

Resurrected and moved.

[Bob Nystrom, 2017-07-18 21:13:00]

Description was changed from

==========
Delete old tests that aren't used and/or useful any more.
==========

to

==========
Delete old tests that aren't used and/or useful any more.

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1d8c3af663e702332fc6e813eb8bc2d644d51d78
==========

[Bob Nystrom, 2017-07-18 21:13:01]

Committed patchset #2 (id:20001) manually as
1d8c3af663e702332fc6e813eb8bc2d644d51d78 (presubmit successful).

[Johnni Winther, 2017-07-19 11:29:58]

johnniwinther@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2017-07-19 11:29:58]

https://codereview.chromium.org/2976313002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/dummy_compiler_test.dart (right):

https://codereview.chromium.org/2976313002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/dummy_compiler_test.dart:1: // Copyright (c) 2012, the
Dart project authors.  Please see the AUTHORS file
This doesn't work. dummy_compiler_test and recursive_import_test were testing
that dart2js could compile dart2js. Putting these in tests/compiler/dart2js
means that only the vm runs these tests (and we know that the vm can run
dart2js.

[Bob Nystrom, 2017-07-19 17:35:34]

On 2017/07/19 11:29:58, Johnni Winther wrote:
> This doesn't work. dummy_compiler_test and recursive_import_test were testing
> that dart2js could compile dart2js. Putting these in tests/compiler/dart2js
> means that only the vm runs these tests (and we know that the vm can run
> dart2js.

Well, dang.

Either way, I'm pretty certain these tests don't belong in tests/utils/, so
moving them out of there is good.

Would you like to send a CL that moves them to where they should be? Maybe
compiler/dart2js_extras?

– bob

[Johnni Winther, 2017-07-21 07:32:04]

On 2017/07/19 17:35:34, Bob Nystrom wrote:
> On 2017/07/19 11:29:58, Johnni Winther wrote:
> > This doesn't work. dummy_compiler_test and recursive_import_test were
testing
> > that dart2js could compile dart2js. Putting these in tests/compiler/dart2js
> > means that only the vm runs these tests (and we know that the vm can run
> > dart2js.
> 
> Well, dang.
> 
> Either way, I'm pretty certain these tests don't belong in tests/utils/, so
> moving them out of there is good.
> 
> Would you like to send a CL that moves them to where they should be? Maybe
> compiler/dart2js_extras?
> 
> – bob

I'll move them to dart2js_extra