Issue 29763002: Enable reference adoption run time checks for Blink+skia in Debug builds

Issue 29763002: Enable reference adoption run time checks for Blink+skia in Debug builds (Closed)

Created:
7 years, 2 months ago by Justin Novosad

Modified:
7 years, 2 months ago

Reviewers:
Stephen White

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable reference adoption run time checks for Blink+skia in Debug builds This change enables run run time check that will help detect memory leaks and unsafe usage in cases where Blink's RefPtr is used to hold a reference to a skia SkRefCnt-derived object. BUG=304265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230161

Patch Set 1 #

Patch Set 2 : added missing newlinewq #

Patch Set 3 : adding missing newline #

Patch Set 4 : add missing newline #

Patch Set 5 : Added missing SK_API #

Total comments: 2

Patch Set 6 : fixed indentation #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -0 lines)			Patch
	M	skia/config/SkUserConfig.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	A	skia/config/sk_ref_cnt_base_debug.h	View	1 2 3 4 5	1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Stephen White

LGTM.. I think. :/ https://codereview.chromium.org/29763002/diff/160001/skia/config/SkUserConfig.h File skia/config/SkUserConfig.h (right): https://codereview.chromium.org/29763002/diff/160001/skia/config/SkUserConfig.h#newcode156 skia/config/SkUserConfig.h:156: #define SK_REF_CNT_BASE_INCLUDE "sk_ref_cnt_base_debug.h" Ew. I ...

7 years, 2 months ago (2013-10-21 22:11:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/29763002/250001

7 years, 2 months ago (2013-10-21 22:22:05 UTC) #4

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=91378

7 years, 2 months ago (2013-10-22 03:22:55 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/29763002/250001

7 years, 2 months ago (2013-10-22 18:03:26 UTC) #6

Message was sent while issue was closed.

Change committed as 230161

Expand Messages | Collapse Messages