Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: tests/compiler/dart2js/kernel/visitor_test.dart

Issue 2976283002: Update expectations. (Closed)
Patch Set: Update compile.status. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/testcases/uninitialized_fields.dart.direct.expect ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/kernel/visitor_test.dart
diff --git a/tests/compiler/dart2js/kernel/visitor_test.dart b/tests/compiler/dart2js/kernel/visitor_test.dart
index 3ccc4508b3dabe21e8f18fcdd073b1528f155f66..ebba93edd48f0cef07272e873e4b07f739c00721 100644
--- a/tests/compiler/dart2js/kernel/visitor_test.dart
+++ b/tests/compiler/dart2js/kernel/visitor_test.dart
@@ -23,7 +23,7 @@ import '../memory_compiler.dart';
const String TESTCASE_DIR = 'pkg/front_end/testcases/';
const List<String> TESTS = const <String>[
- // 'DeltaBlue', Issue 29853: default constructor _not expected
+ // 'DeltaBlue', Issue 29853: super calls compiled as direct calls.
'argument',
'arithmetic',
'async_function',
@@ -32,9 +32,10 @@ const List<String> TESTS = const <String>[
'closure',
// 'covariant_generic', Issue 29853: typedefs
'escape',
- 'fallthrough',
+ // 'fallthrough', Issue 29853: fall-through errors compiled differently from
+ // Fasta
'micro',
- // 'named_parameters', Issue 29853: default constructor _not expected
+ 'named_parameters',
'null_aware',
'optional',
'override',
@@ -43,7 +44,7 @@ const List<String> TESTS = const <String>[
'static_setter',
'store_load',
'stringliteral',
- // 'uninitialized_fields', Issue 29853: default constructor _not expected
+ // 'uninitialized_fields', Issue 29853: Disagrement on field initializers.
'unused_methods',
'void-methods',
];
« no previous file with comments | « pkg/front_end/testcases/uninitialized_fields.dart.direct.expect ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698