Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2976263002: Resynthesize methods from Kernel. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix for sync* and test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -84 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 7 chunks +40 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 2 chunks +21 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 8 chunks +1 line, -75 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 5 months ago (2017-07-16 18:05:21 UTC) #1
Paul Berry
lgtm assuming the issue below is addressed. https://codereview.chromium.org/2976263002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2976263002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode3885 pkg/analyzer/lib/src/dart/element/element.dart:3885: return _kernel.function.asyncMarker ...
3 years, 5 months ago (2017-07-17 15:22:50 UTC) #2
scheglov
https://codereview.chromium.org/2976263002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2976263002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode3885 pkg/analyzer/lib/src/dart/element/element.dart:3885: return _kernel.function.asyncMarker == kernel.AsyncMarker.AsyncStar; On 2017/07/17 15:22:50, Paul Berry ...
3 years, 5 months ago (2017-07-17 15:37:21 UTC) #3
scheglov
3 years, 5 months ago (2017-07-17 15:37:38 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
892d7caab39188ecc1c1c4381d1e24aedd0b8147 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698