Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2976213002: Allow setting unknown CSS properties, e.g. CSS variables (Closed)

Created:
3 years, 5 months ago by Alan Knight
Modified:
3 years, 5 months ago
Reviewers:
terry, sra
CC:
reviews_dartlang.org, zra
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow setting unknown CSS properties, e.g. CSS variables BUG= R=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/789de57cdfe5649ac46b22f4a0fdcbfd6b93c5af

Patch Set 1 #

Patch Set 2 : cached patches #

Patch Set 3 : Update status files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -52 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 3 chunks +16 lines, -12 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 3 chunks +16 lines, -12 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M tests/co19/co19-dartium.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/scripts/css_code_generator.py View 1 3 chunks +16 lines, -12 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 3 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Alan Knight
3 years, 5 months ago (2017-07-17 19:53:08 UTC) #2
Alan Knight
3 years, 5 months ago (2017-07-17 19:53:35 UTC) #4
Alan Knight
3 years, 5 months ago (2017-07-17 19:53:36 UTC) #5
terry
lgtm
3 years, 5 months ago (2017-07-17 21:27:15 UTC) #7
Alan Knight
3 years, 5 months ago (2017-07-17 21:56:51 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
789de57cdfe5649ac46b22f4a0fdcbfd6b93c5af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698