Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2976133002: Support ClassMirror.newInstance on factory constructors (Closed)

Created:
3 years, 5 months ago by vsm
Modified:
3 years, 5 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support ClassMirror.newInstance on factory constructors R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/d952055a7ea7be9e695070531c81050ca5c352b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
vsm
3 years, 5 months ago (2017-07-13 20:00:07 UTC) #2
Jennifer Messerly
LGTM :)
3 years, 5 months ago (2017-07-13 20:01:05 UTC) #3
vsm
3 years, 5 months ago (2017-07-13 20:07:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d952055a7ea7be9e695070531c81050ca5c352b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698