Issue 2976103002: cleanup fasta parser send and expression events

Issue 2976103002: cleanup fasta parser send and expression events (Closed)

Created:
3 years, 5 months ago by danrubel

Modified:
3 years, 5 months ago

Reviewers:
ahe, scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

cleanup fasta parser send and expression events * remove unused beginSend * rename endSend to handleSend * remove unused beginThrowExpression * remove unused beginExpression event * rename endThrowExpression to handleThrowExpression R=ahe@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/14b76d6b22dff51090228de771888630058684a5

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -58 lines)			Patch
M	pkg/analyzer/lib/src/fasta/ast_builder.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_fasta_listener.dart	View	1	7 chunks	+13 lines, -32 lines	0 comments	Download
M	pkg/analyzer/tool/summary/mini_ast.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/parser/node_listener.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/kernel/body_builder.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/parser/listener.dart	View		3 chunks	+2 lines, -8 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/parser/parser.dart	View		10 chunks	+5 lines, -11 lines	0 comments	Download

Total messages: 7 (2 generated)

ahe

lgtm I recommend that you test this on dart2js as well: ./pkg/front_end/tool/fasta testing fasta_max

3 years, 5 months ago (2017-07-13 16:54:51 UTC) #4

danrubel

On 2017/07/13 16:54:51, ahe wrote: > lgtm > > I recommend that you test this ...

3 years, 5 months ago (2017-07-13 16:55:54 UTC) #5

danrubel

3 years, 5 months ago (2017-07-14 14:20:14 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
14b76d6b22dff51090228de771888630058684a5 (presubmit successful).