Issue 2976008: Bar - Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2976008: Bar (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Nico

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org, jam, darin-cc_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Bar Closed in favor of http://codereview.chromium.org/3163003/show , which has the pieces of this CL that aren't landed yet.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Patch Set 12 : '' #

Patch Set 13 : ''! #

Patch Set 14 : demo #

Patch Set 15 : rebase #

Patch Set 16 : rebase #

Patch Set 17 : rebase #

Patch Set 18 : remove some printfs #

Patch Set 19 : rebase #

Patch Set 20 : rebase #

Patch Set 21 : more rebase #

Patch Set 22 : rebase #

Patch Set 23 : '' #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+744 lines, -16 lines)			Patch
M	chrome/browser/cocoa/bookmark_bar_controller.h	View	13 14 15 16 17 18	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.mm	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/tab_strip_controller.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/tabpose_window.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19	2 chunks	+37 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/tabpose_window.mm	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	7 chunks	+702 lines, -8 lines	0 comments	Download
M	chrome/browser/cocoa/tabpose_window_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Trybot results: