Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2976003002: Implement IncrementalKernelGeneratorImpl using KernelDriver. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement IncrementalKernelGeneratorImpl using KernelDriver. What is not done, and I'd like to do in following CLs. 1. Write documentation for KernelDriver. 2. Add separate tests for KernelDriver. R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a9a926a197df8cc88d34ab370caa6ea4df176ea4

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -372 lines) Patch
A + pkg/front_end/lib/src/incremental/kernel_driver.dart View 1 11 chunks +88 lines, -105 lines 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 6 chunks +31 lines, -266 lines 0 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-07-11 21:50:49 UTC) #1
Paul Berry
lgtm assuming documentation is added https://codereview.chromium.org/2976003002/diff/1/pkg/front_end/lib/src/incremental/kernel_driver.dart File pkg/front_end/lib/src/incremental/kernel_driver.dart (right): https://codereview.chromium.org/2976003002/diff/1/pkg/front_end/lib/src/incremental/kernel_driver.dart#newcode29 pkg/front_end/lib/src/incremental/kernel_driver.dart:29: /// TODO(scheglov) Improve the ...
3 years, 5 months ago (2017-07-12 17:04:43 UTC) #2
scheglov
3 years, 5 months ago (2017-07-12 18:24:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a9a926a197df8cc88d34ab370caa6ea4df176ea4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698