Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2975953002: Fixed readPixels not working in Dartium. (Closed)

Created:
3 years, 5 months ago by terry
Modified:
3 years, 5 months ago
Reviewers:
Alan Knight, Jacob
CC:
reviews_dartlang.org, zra
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Updated to latest WebKit (exposed Dart_TypedArray_ArrayBufferView). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -11 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/js/dartium/js_dartium.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 5 chunks +20 lines, -3 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 5 chunks +26 lines, -5 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/dom/templates/html/impl/impl_WebGL2RenderingContext.darttemplate View 1 chunk +26 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WebGLRenderingContext.darttemplate View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
terry
3 years, 5 months ago (2017-07-11 19:50:36 UTC) #1
Alan Knight
lgtm
3 years, 5 months ago (2017-07-11 19:53:05 UTC) #2
terry
3 years, 5 months ago (2017-07-11 20:13:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1265b4c6742487c025ebae97852d555cfd9d6522 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698