Check emitter constants and fix tearOffName for JConstructorBody

Check emitter constants and fix tearOffName for JConstructorBody

R=sigmund@google.com, sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/72e8925206019594a2c807da3a49af68c2f1d6dd

[Johnni Winther, 2017-07-11 18:08:11]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2017-07-11 18:24:04]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-07-11 18:24:05]

lgtm, but I'm not sure which part achieves "fix tearOffName for
JConstructorBody"

https://codereview.chromium.org/2975933002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/2975933002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/model.dart:397: return
'method[name=${name},element=${element}'
FWIW I prefer these debug-oriented strings to have the same name as the class
and use parens and source-code-like spacing, e.g.

    Method(name=x, element=z)

rather than

    method[name=x,element=z].

If we consistently use the class name then it is easier to know where to look
for the definition.

[Johnni Winther, 2017-07-11 18:39:53]

On 2017/07/11 18:24:05, sra1 wrote:
> lgtm, but I'm not sure which part achieves "fix tearOffName for
> JConstructorBody"
> 
Removing JConstructorBody.isFunction. It shouldn't have been there and trigger
the creation of a tearOffName.

[Siggi Cherem (dart-lang), 2017-07-11 21:18:01]

lgtm

[Johnni Winther, 2017-07-12 08:37:27]

Description was changed from

==========
Check emitter constants and fix tearOffName for JConstructorBody
==========

to

==========
Check emitter constants and fix tearOffName for JConstructorBody

R=sigmund@google.com, sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/72e8925206019594a2c807da3a49af68c2f1d6dd
==========

[Johnni Winther, 2017-07-12 08:37:29]

Committed patchset #1 (id:1) manually as
72e8925206019594a2c807da3a49af68c2f1d6dd (presubmit successful).

[Johnni Winther, 2017-07-12 10:03:24]

https://codereview.chromium.org/2975933002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/2975933002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/model.dart:397: return
'method[name=${name},element=${element}'
On 2017/07/11 18:24:05, sra1 wrote:
> FWIW I prefer these debug-oriented strings to have the same name as the class
> and use parens and source-code-like spacing, e.g.
> 
>     Method(name=x, element=z)
> 
> rather than
> 
>     method[name=x,element=z].
> 
> If we consistently use the class name then it is easier to know where to look
> for the definition.

Will change in a follow-up CL.