Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2975823002: Remove all deprecated fasta message methods from analyzer. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove all deprecated fasta message methods from analyzer. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/710ddf02fff7db4df16c1d9ee5d6304b439533cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -240 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 10 chunks +15 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/element_store.dart View 6 chunks +20 lines, -19 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/mock_element.dart View 7 chunks +150 lines, -137 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/mock_type.dart View 1 chunk +68 lines, -61 lines 0 comments Download
M pkg/analyzer/tool/summary/mini_ast.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 3 chunks +80 lines, -0 lines 0 comments Download
A pkg/front_end/lib/src/fasta/problems.dart View 1 chunk +50 lines, -0 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 5 months ago (2017-07-10 19:44:09 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 5 months ago (2017-07-10 19:55:13 UTC) #3
ahe
3 years, 5 months ago (2017-07-11 07:26:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
710ddf02fff7db4df16c1d9ee5d6304b439533cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698