Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2975793005: Fix incremental_reload example after VmReloader -> RemoteVm rename. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix incremental_reload example after VmReloader -> RemoteVm rename. TBR There were 2 compilation errors and 1 hint. I prefer when my workspace is error free :-) R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fac4d2d6035a642cdf41d8cd4b278e26af0d8238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pkg/front_end/example/incremental_reload/run.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 5 months ago (2017-07-11 19:03:18 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as fac4d2d6035a642cdf41d8cd4b278e26af0d8238 (presubmit successful).
3 years, 5 months ago (2017-07-11 19:12:04 UTC) #3
Paul Berry
lgtm
3 years, 5 months ago (2017-07-11 19:12:47 UTC) #4
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-11 20:26:14 UTC) #5
Message was sent while issue was closed.
lgtm, thanks, we should include this in our analyzer tests I don't miss it again
in the future.

Powered by Google App Engine
This is Rietveld 408576698