Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1783)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwVariationsSeedFetchService.java

Issue 2975693002: Add AwVariationsSeedFetchService and refactory VariationsSeedFetcher (Closed)
Patch Set: Update a bug in deleting file Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwVariationsSeedFetchService.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwVariationsSeedFetchService.java b/android_webview/java/src/org/chromium/android_webview/AwVariationsSeedFetchService.java
new file mode 100644
index 0000000000000000000000000000000000000000..f46436c15542faef896fbbabc8cdcfb5bf7c5084
--- /dev/null
+++ b/android_webview/java/src/org/chromium/android_webview/AwVariationsSeedFetchService.java
@@ -0,0 +1,173 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.android_webview;
+
+import android.annotation.TargetApi;
+import android.app.job.JobParameters;
+import android.app.job.JobService;
+import android.os.AsyncTask;
+import android.os.Build;
+
+import org.chromium.base.ContextUtils;
+import org.chromium.base.Log;
+import org.chromium.base.ThreadUtils;
+import org.chromium.components.variations.firstrun.VariationsSeedFetcher;
+import org.chromium.components.variations.firstrun.VariationsSeedFetcher.SeedInfo;
+
+import java.io.Closeable;
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.io.Serializable;
+import java.util.concurrent.locks.Lock;
+import java.util.concurrent.locks.ReentrantLock;
+
+/**
+ * AwVariationsSeedFetchService is a Job Service to fetch test seed data which is used by Finch
+ * to enable AB testing experiments in the native code. The fetched data is stored in the local
+ * directory which belongs to the Service process.
+ */
+@TargetApi(Build.VERSION_CODES.LOLLIPOP) // JobService requires API level 21.
+public class AwVariationsSeedFetchService extends JobService {
+ private static final String TAG = "AwVartnsSeedFetchSvc";
+
+ public static final String WEBVIEW_VARIATIONS_DIR = "WebView_Variations/";
+ public static final String SEED_DATA_FILENAME = "variations_seed_data";
+ public static final String SEED_PREF_FILENAME = "variations_seed_pref";
+
+ // Synchronization lock to prevent simultaneous local seed file writing.
+ private static final Lock sLock = new ReentrantLock();
+
+ @Override
+ public boolean onStartJob(JobParameters params) {
+ // Ensure we can use ContextUtils later on.
+ ContextUtils.initApplicationContext(this.getApplicationContext());
+ new FetchFinchSeedDataTask(params).execute();
+ return true;
+ }
+
+ @Override
+ public boolean onStopJob(JobParameters params) {
+ // The function will only be called before jobFinished when job parameters are no longer
+ // satisfied. The function returns true to make the task rescheduled.
+ return true;
+ }
+
+ private class FetchFinchSeedDataTask extends AsyncTask<Void, Void, Void> {
+ private JobParameters mJobParams;
+
+ FetchFinchSeedDataTask(JobParameters params) {
+ mJobParams = params;
+ }
+
+ @Override
+ protected Void doInBackground(Void... params) {
+ AwVariationsSeedFetchService.fetchSeed();
+ return null;
+ }
+
+ @Override
+ protected void onPostExecute(Void success) {
+ jobFinished(mJobParams, false /* false -> don't reschedule */);
+ }
+ }
+
+ private static void fetchSeed() {
+ assert !ThreadUtils.runningOnUiThread();
+ // TryLock will drop calls from other threads when there is a thread executing the function.
+ // TODO(yiyuny): Add explicitly control to ensure there's only one threading fetching at a
+ // time and that the seed doesn't get fetched too frequently
+ if (sLock.tryLock()) {
+ try {
+ SeedInfo seedInfo = VariationsSeedFetcher.get().downloadContent(
+ VariationsSeedFetcher.VariationsPlatform.ANDROID_WEBVIEW, "");
+ storeVariationsSeed(seedInfo);
+ } catch (IOException e) {
+ // Exceptions are handled and logged in the downloadContent function and re-throwing
gsennton 2017/07/14 12:45:39 "Exceptions are handled and logged in the download
yiyuny 2017/07/15 00:19:00 Thanks!
+ // exceptions is to stop the normal logic flow after it, so no error-handling here.
+ // Not explicitly handing SocketTimeoutException and UnknownHostException for they
+ // are both subclasses of IOException.
+ } finally {
+ sLock.unlock();
+ }
+ }
+ }
+
+ /**
+ * SeedPreference is used to serialize/deserialize related fields of seed data when reading or
+ * writing them to the internal storage.
+ */
+ public static class SeedPreference implements Serializable {
+ /**
+ * Let the program deserialize the data when the fields are changed.
+ */
+ private static final long serialVersionUID = 0L;
+
+ public final String signature;
+ public final String country;
+ public final String date;
+ public final boolean isGzipCompressed;
+
+ public SeedPreference(SeedInfo seedInfo) {
+ signature = seedInfo.signature;
+ country = seedInfo.country;
+ date = seedInfo.date;
+ isGzipCompressed = seedInfo.isGzipCompressed;
+ }
+ }
+
+ private static File getOrCreateWebViewVariationsDir() {
+ File webViewFileDir = ContextUtils.getApplicationContext().getFilesDir();
+ File dir = new File(webViewFileDir, WEBVIEW_VARIATIONS_DIR);
+ if (dir.mkdir() || dir.isDirectory()) {
+ return dir;
+ }
+ return null;
+ }
+
+ private static void storeVariationsSeed(SeedInfo seedInfo) {
+ File webViewVariationsDir = getOrCreateWebViewVariationsDir();
+ if (webViewVariationsDir == null) {
+ Log.e(TAG, "Failed to get or create the webview variations directory.");
+ return;
+ }
+
+ FileOutputStream fosSeedData = null;
+ ObjectOutputStream oosSeedPref = null;
+ try {
+ File seedDataFile = File.createTempFile(SEED_DATA_FILENAME, null, webViewVariationsDir);
+ fosSeedData = new FileOutputStream(seedDataFile);
+ fosSeedData.write(seedInfo.seedData, 0, seedInfo.seedData.length);
+ renameTempFile(seedDataFile, new File(webViewVariationsDir, SEED_DATA_FILENAME));
+ // Store separately so that reading large seed data (which is expensive) can be
+ // prevented when checking the last seed fetch time.
+ File seedPrefFile = File.createTempFile(SEED_PREF_FILENAME, null, webViewVariationsDir);
+ oosSeedPref = new ObjectOutputStream(new FileOutputStream(seedPrefFile));
+ oosSeedPref.writeObject(new SeedPreference(seedInfo));
+ renameTempFile(seedPrefFile, new File(webViewVariationsDir, SEED_PREF_FILENAME));
+ } catch (IOException e) {
+ Log.e(TAG, "IOException failed to write variations seed data or preference to a file.");
+ } finally {
+ closeStream(fosSeedData, SEED_DATA_FILENAME);
+ closeStream(oosSeedPref, SEED_PREF_FILENAME);
+ }
+ }
+
+ private static void renameTempFile(File tempFile, File newFile) {
+ newFile.delete();
+ tempFile.renameTo(newFile);
+ }
+
+ private static void closeStream(Closeable stream, String filename) {
+ if (stream != null) {
+ try {
+ stream.close();
+ } catch (IOException e) {
+ Log.e(TAG, "IOException failed to close " + filename + " file.");
+ }
+ }
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698