Add GeolocationManager service

content/browser/service_manager/common_browser_interfaces.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_manager/common_browser_interfaces.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/callback.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/task_runner.h"
 #include "components/discardable_memory/service/discardable_shared_memory_manager.h"
 #include "content/browser/browser_main_loop.h"
 #include "content/public/common/connection_filter.h"
 #include "content/public/common/service_manager_connection.h"
+#include "device/geolocation/geolocation_manager.h"
 #include "mojo/public/cpp/bindings/interface_request.h"
 #include "services/resource_coordinator/memory_instrumentation/coordinator_impl.h"
 #include "services/service_manager/public/cpp/binder_registry.h"
 
 namespace content {
 
 namespace {
 
 void BindMemoryCoordinatorRequest(
     const service_manager::BindSourceInfo& source_info,
@@ skipping 46 matching lines @@
       const service_manager::BindSourceInfo& source_info,
       mojo::InterfaceRequest<Interface> request) {
     task_runner->PostTask(
         FROM_HERE, base::BindOnce(binder, source_info, std::move(request)));
   }
 
   template <typename Interface>
   void RegisterMainThreadInterface(const InterfaceBinder<Interface>& binder) {
     registry_.AddInterface(base::Bind(&BindOnTaskRunner<Interface>,
                                       main_thread_task_runner_, binder));
+
+    registry_.AddInterface(base::Bind(&device::GeolocationManager::Create));

[blundell, 2017/07/11 09:08:34]

I think what you want to do is add a *call* to RegisterMainThreadInterface() up
by line 38 in this file (where there's the call for MemoryCoordinator). That
said, this file seems like a weird place to put this as we're only exposing this
interface to the browser process. Ken, is there a better place to put this? Note
that wherever we put it is temporary anyway as it will be hosted by the Device
Service once we servicify geolocation, so maybe it doesn't matter too much.

[asimjour1, 2017/07/11 15:04:12]

replaced with a call to RegisterMainThreadInterface

[Ken Rockot(use gerrit already), 2017/07/11 15:22:55]

It's a bit weird but it seems OK to me given that it's temporary.

   }
 
   const scoped_refptr<base::TaskRunner> main_thread_task_runner_;
   service_manager::BinderRegistry registry_;
 
   DISALLOW_COPY_AND_ASSIGN(ConnectionFilterImpl);
 };
 
 }  // namespace
 
 void RegisterCommonBrowserInterfaces(ServiceManagerConnection* connection) {
   connection->AddConnectionFilter(base::MakeUnique<ConnectionFilterImpl>());
 }
 
 }  // namespace content