Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5457)

Unified Diff: chrome/browser/resources/print_preview/preview_generator.js

Issue 2975663003: Print Preview: Fix followup issues for removing global JS functions (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/preview_generator.js
diff --git a/chrome/browser/resources/print_preview/preview_generator.js b/chrome/browser/resources/print_preview/preview_generator.js
index aaff184f5673c9bd3454499d9f6c7041bd4301ca..f8c06cf6288d075cf4bfeb918951186aa634957a 100644
--- a/chrome/browser/resources/print_preview/preview_generator.js
+++ b/chrome/browser/resources/print_preview/preview_generator.js
@@ -14,11 +14,14 @@ cr.define('print_preview', function() {
* @param {!print_preview.NativeLayer} nativeLayer Used to communicate to
* Chromium's preview rendering system.
* @param {!print_preview.DocumentInfo} documentInfo Document data model.
+ * @param {!WebUIListenerTracker} listenerTracker Tracker for the WebUI
+ * listeners added in the PreviewGenerator constructor.
* @constructor
* @extends {cr.EventTarget}
*/
function PreviewGenerator(
- destinationStore, printTicketStore, nativeLayer, documentInfo) {
+ destinationStore, printTicketStore, nativeLayer, documentInfo,
+ listenerTracker) {
cr.EventTarget.call(this);
/**
@@ -135,6 +138,8 @@ cr.define('print_preview', function() {
* @private
*/
this.selectedDestination_ = null;
+
+ this.addWebUIEventListeners_(listenerTracker);
}
/**
@@ -166,8 +171,9 @@ cr.define('print_preview', function() {
* |listenerTracker|. |listenerTracker| is responsible for removing the
* listeners when necessary.
* @param {!WebUIListenerTracker} listenerTracker
+ * @private
*/
- addWebUIEventListeners: function(listenerTracker) {
+ addWebUIEventListeners_: function(listenerTracker) {
listenerTracker.add(
'page-count-ready', this.onPageCountReady_.bind(this));
listenerTracker.add(

Powered by Google App Engine
This is Rietveld 408576698