Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 297563002: Roll DomDistillerJs (and make updater generate BUG=) (Closed)

Created:
6 years, 7 months ago by cjhopman
Modified:
6 years, 7 months ago
Reviewers:
nyquist
CC:
chromium-reviews, kuan, Yaron
Visibility:
Public.

Description

Roll DomDistillerJs (and make updater generate BUG=) The updater now pulls BUG= lines out of the git log and processes/sorts/uniqifies them and prints them for even better commit messages. Picked up changes: 6ef4764 Extend visibility checks to images that are extracted. 6e8c385 Updated Boilerpipe with some more modern tags. cde81dc Add extract_text_only option 0a31800 filter out invisible elements 82b35ba Fix crash when content extraction fails. BUG=354157, 356336, 362085, 364356, 367243 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271582

Patch Set 1 #

Patch Set 2 : Now with BUG= #

Total comments: 4

Patch Set 3 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+538 lines, -492 lines) Patch
M third_party/dom_distiller_js/README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/package/js/domdistiller.js View 1 1 chunk +498 lines, -489 lines 0 comments Download
M third_party/dom_distiller_js/package/proto/dom_distiller.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/dom_distiller_js/package/proto_gen/third_party/dom_distiller_js/dom_distiller_json_converter.h View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/dom_distiller_js/update_domdistiller_js.sh View 1 2 3 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
cjhopman
nyquist: *
6 years, 7 months ago (2014-05-19 21:55:10 UTC) #1
nyquist
lgtm
6 years, 7 months ago (2014-05-19 22:05:50 UTC) #2
cjhopman
Now with BUG=. Might want to take another quick look at this for the changes ...
6 years, 7 months ago (2014-05-19 22:35:04 UTC) #3
nyquist
https://codereview.chromium.org/297563002/diff/60001/third_party/dom_distiller_js/update_domdistiller_js.sh File third_party/dom_distiller_js/update_domdistiller_js.sh (right): https://codereview.chromium.org/297563002/diff/60001/third_party/dom_distiller_js/update_domdistiller_js.sh#newcode34 third_party/dom_distiller_js/update_domdistiller_js.sh:34: | sed -e 's/.*BUG=\(.*\)/\1/' -e 's/\s*//g' -e '/^$/d' \ ...
6 years, 7 months ago (2014-05-19 22:41:25 UTC) #4
cjhopman
https://codereview.chromium.org/297563002/diff/60001/third_party/dom_distiller_js/update_domdistiller_js.sh File third_party/dom_distiller_js/update_domdistiller_js.sh (right): https://codereview.chromium.org/297563002/diff/60001/third_party/dom_distiller_js/update_domdistiller_js.sh#newcode34 third_party/dom_distiller_js/update_domdistiller_js.sh:34: | sed -e 's/.*BUG=\(.*\)/\1/' -e 's/\s*//g' -e '/^$/d' \ ...
6 years, 7 months ago (2014-05-19 22:57:57 UTC) #5
nyquist
still lgtm
6 years, 7 months ago (2014-05-19 22:59:08 UTC) #6
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 7 months ago (2014-05-19 23:01:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/297563002/80001
6 years, 7 months ago (2014-05-19 23:02:29 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 03:18:22 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 06:23:15 UTC) #10
Message was sent while issue was closed.
Change committed as 271582

Powered by Google App Engine
This is Rietveld 408576698