Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2975583002: Update docs on Stream.skip/take/skipWhile/takeWhile. (Closed)

Created:
3 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update docs on Stream.skip/take/skipWhile/takeWhile. Fixes #30101, #30088 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/32a2d2079af113dfcca50e9388cc578d6073dc5a

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -15 lines) Patch
M sdk/lib/async/stream.dart View 1 7 chunks +40 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Lasse Reichstein Nielsen
3 years, 5 months ago (2017-07-07 11:34:34 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/2975583002/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/2975583002/diff/1/sdk/lib/async/stream.dart#newcode1047 sdk/lib/async/stream.dart:1047: * before being done, the returned stream will ...
3 years, 5 months ago (2017-07-07 11:45:51 UTC) #3
Lasse Reichstein Nielsen
3 years, 5 months ago (2017-07-07 11:52:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
32a2d2079af113dfcca50e9388cc578d6073dc5a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698