Issue 2975573002: Lookup getClosureScope by member instead of node

Issue 2975573002: Lookup getClosureScope by member instead of node (Closed)

Created:
3 years, 5 months ago by Johnni Winther

Modified:
3 years, 5 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -15 lines)			Patch
M	pkg/compiler/lib/src/closure.dart	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_model/closure.dart	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View		5 chunks	+4 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View		3 chunks	+4 lines, -5 lines	0 comments	Download

Total messages: 7 (2 generated)

Emily Fortuna

what's the rationale for this? It works, but why not just look up by ir ...

3 years, 5 months ago (2017-07-07 17:33:43 UTC) #3

Johnni Winther

On 2017/07/07 17:33:43, Emily Fortuna wrote: > what's the rationale for this? It works, but ...

3 years, 5 months ago (2017-07-10 10:07:54 UTC) #4

Johnni Winther

On 2017/07/07 17:33:43, Emily Fortuna wrote: > what's the rationale for this? It works, but ...

3 years, 5 months ago (2017-07-10 11:00:03 UTC) #5

Johnni Winther

3 years, 5 months ago (2017-07-10 11:00:12 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5dbd50204e9be3e9f1a56f0ea5c545a7429488ca (presubmit successful).