Add callback in VideoDecoder and AudioDecoder to return decoded frames.

media/filters/fake_video_decoder.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/fake_video_decoder.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "media/base/bind_to_current_loop.h"
 #include "media/base/test_helpers.h"
 
 namespace media {
 
 FakeVideoDecoder::FakeVideoDecoder(int decoding_delay,
-                                   bool supports_get_decode_output,
                                    int max_parallel_decoding_requests)
     : decoding_delay_(decoding_delay),
-      supports_get_decode_output_(supports_get_decode_output),
       max_parallel_decoding_requests_(max_parallel_decoding_requests),
       state_(STATE_UNINITIALIZED),
       hold_decode_(false),
       total_bytes_decoded_(0),
       weak_factory_(this) {
   DCHECK_GE(decoding_delay, 0);
 }
 
 FakeVideoDecoder::~FakeVideoDecoder() {
   DCHECK_EQ(state_, STATE_UNINITIALIZED);
 }
 
 void FakeVideoDecoder::Initialize(const VideoDecoderConfig& config,
                                   bool low_delay,
-                                  const PipelineStatusCB& status_cb) {
+                                  const PipelineStatusCB& status_cb,
+                                  const OutputCB& output_cb) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(config.IsValidConfig());
   DCHECK(held_decode_callbacks_.empty())
       << "No reinitialization during pending decode.";
   DCHECK(reset_cb_.IsNull()) << "No reinitialization during pending reset.";
 
   current_config_ = config;
   init_cb_.SetCallback(BindToCurrentLoop(status_cb));
+  output_cb_ = output_cb;

[xhwang, 2014/06/05 21:53:49]

This should be okay. But add a comment why we don't need to BindToCurrentLoop()
here?

[Sergey Ulanov, 2014/06/06 22:49:40]

Done.

 
   if (!decoded_frames_.empty()) {
     DVLOG(1) << "Decoded frames dropped during reinitialization.";
     decoded_frames_.clear();
   }
 
   state_ = STATE_NORMAL;
   init_cb_.RunOrHold(PIPELINE_OK);
 }
 
 void FakeVideoDecoder::Decode(const scoped_refptr<DecoderBuffer>& buffer,
                               const DecodeCB& decode_cb) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(reset_cb_.IsNull());
   DCHECK_LE(decoded_frames_.size(),
             decoding_delay_ + held_decode_callbacks_.size());
   DCHECK_LT(static_cast<int>(held_decode_callbacks_.size()),
             max_parallel_decoding_requests_);
 
   int buffer_size = buffer->end_of_stream() ? 0 : buffer->data_size();
   DecodeCB wrapped_decode_cb =
       BindToCurrentLoop(base::Bind(&FakeVideoDecoder::OnFrameDecoded,
                                    weak_factory_.GetWeakPtr(),
-                                   buffer_size,
-                                   decode_cb));
+                                   buffer_size, decode_cb));
 
   if (state_ == STATE_ERROR) {
-    wrapped_decode_cb.Run(kDecodeError, scoped_refptr<VideoFrame>());
+    wrapped_decode_cb.Run(kDecodeError);
     return;
   }
 
   if (buffer->end_of_stream()) {
     state_ = STATE_END_OF_STREAM;
   } else {
     DCHECK(VerifyFakeVideoBufferForTest(buffer, current_config_));
     scoped_refptr<VideoFrame> video_frame = VideoFrame::CreateColorFrame(
         current_config_.coded_size(), 0, 0, 0, buffer->timestamp());
     decoded_frames_.push_back(video_frame);
@@ skipping 23 matching lines @@
     SatisfyInit();
   if (!held_decode_callbacks_.empty())
     SatisfyDecode();
   if (!reset_cb_.IsNull())
     SatisfyReset();
 
   decoded_frames_.clear();
   state_ = STATE_UNINITIALIZED;
 }
 
-scoped_refptr<VideoFrame> FakeVideoDecoder::GetDecodeOutput() {
-  DCHECK(thread_checker_.CalledOnValidThread());
-  if (!supports_get_decode_output_ || decoded_frames_.empty())
-    return NULL;
-  scoped_refptr<VideoFrame> out = decoded_frames_.front();
-  decoded_frames_.pop_front();
-  return out;
-}
-
 void FakeVideoDecoder::HoldNextInit() {
   DCHECK(thread_checker_.CalledOnValidThread());
   init_cb_.HoldCallback();
 }
 
 void FakeVideoDecoder::HoldDecode() {
   DCHECK(thread_checker_.CalledOnValidThread());
   hold_decode_ = true;
 }
 
@@ skipping 37 matching lines @@
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(held_decode_callbacks_.empty());
   reset_cb_.RunHeldCallback();
 }
 
 void FakeVideoDecoder::SimulateError() {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   state_ = STATE_ERROR;
   while (!held_decode_callbacks_.empty()) {
-    held_decode_callbacks_.front().Run(kDecodeError,
-                                       scoped_refptr<VideoFrame>());
+    held_decode_callbacks_.front().Run(kDecodeError);
     held_decode_callbacks_.pop_front();
   }
   decoded_frames_.clear();
 }
 
 int FakeVideoDecoder::GetMaxDecodeRequests() const {
   return max_parallel_decoding_requests_;
 }
 
-void FakeVideoDecoder::OnFrameDecoded(
-    int buffer_size,
-    const DecodeCB& decode_cb,
-    Status status,
-    const scoped_refptr<VideoFrame>& video_frame) {
+void FakeVideoDecoder::OnFrameDecoded(int buffer_size,
+                                      const DecodeCB& decode_cb,
+                                      Status status) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
-  if (status == kOk || status == kNotEnoughData)
+  if (status == kOk)
     total_bytes_decoded_ += buffer_size;
-  decode_cb.Run(status, video_frame);
+  decode_cb.Run(status);
 }
 
 void FakeVideoDecoder::RunOrHoldDecode(const DecodeCB& decode_cb) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   if (hold_decode_) {
     held_decode_callbacks_.push_back(decode_cb);
   } else {
     DCHECK(held_decode_callbacks_.empty());
     RunDecodeCallback(decode_cb);
   }
 }
 
 void FakeVideoDecoder::RunDecodeCallback(const DecodeCB& decode_cb) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   if (!reset_cb_.IsNull()) {
     DCHECK(decoded_frames_.empty());
-    decode_cb.Run(kAborted, scoped_refptr<VideoFrame>());
+    decode_cb.Run(kAborted);
     return;
   }
 
   // Make sure we leave decoding_delay_ frames in the queue and also frames for
   // all pending decode callbacks, except the current one.
-  if (decoded_frames_.size() <=
-          decoding_delay_ + held_decode_callbacks_.size() &&
-      state_ != STATE_END_OF_STREAM) {
-    decode_cb.Run(kNotEnoughData, scoped_refptr<VideoFrame>());
-    return;
+  if (decoded_frames_.size() >
+      decoding_delay_ + held_decode_callbacks_.size()) {
+    output_cb_.Run(decoded_frames_.front());
+    decoded_frames_.pop_front();
+  } else if (state_ == STATE_END_OF_STREAM) {
+    // Drain the queue if this was the last request in the stream, otherwise
+    // just pop the last frame from the queue.
+    if (held_decode_callbacks_.empty()) {
+      while (!decoded_frames_.empty()) {
+        output_cb_.Run(decoded_frames_.front());
+        decoded_frames_.pop_front();
+      }
+      output_cb_.Run(VideoFrame::CreateEOSFrame());
+    } else if (!decoded_frames_.empty()) {
+      output_cb_.Run(decoded_frames_.front());
+      decoded_frames_.pop_front();
+    }
   }
 
-  scoped_refptr<VideoFrame> frame;
-  if (decoded_frames_.empty()) {
-    DCHECK_EQ(state_, STATE_END_OF_STREAM);
-    frame = VideoFrame::CreateEOSFrame();
-  } else {
-    frame = decoded_frames_.front();
-    decoded_frames_.pop_front();
-  }
-  decode_cb.Run(kOk, frame);
+  decode_cb.Run(kOk);
 }
 
 void FakeVideoDecoder::DoReset() {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(held_decode_callbacks_.empty());
   DCHECK(!reset_cb_.IsNull());
 
   reset_cb_.RunOrHold();
 }
 
 }  // namespace media