Issue 2975513003: Fix js_model/model_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2975513003: Fix js_model/model_test (Closed)

Created:
3 years, 5 months ago by Johnni Winther

Modified:
3 years, 5 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix js_model/model_test - by adding a JLocalFunction Committed: https://github.com/dart-lang/sdk/commit/78e82212bcb969a4f00b64ac083a5685fe85e106

Patch Set 1 #

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -14 lines)			Patch
M	pkg/compiler/lib/src/js_model/closure_visitors.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_model/elements.dart	View	2 chunks	+18 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/kernel/element_map_impl.dart	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/kelements.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/dart2js.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

Committed patchset #1 (id:1) manually as 78e82212bcb969a4f00b64ac083a5685fe85e106 (presubmit successful).

3 years, 5 months ago (2017-07-07 08:15:21 UTC) #4

Emily Fortuna

3 years, 5 months ago (2017-07-07 17:23:47 UTC) #5

Message was sent while issue was closed.

lgtm

yay, thanks! That would have taken me much longer to figure out the cause of --
I saw the stack overflow error on the test and was like ... ¯\_(ツ)_/¯

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages