Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2975443002: Don't use `LinkedList` in the core libraries anymore. (Closed)

Created:
3 years, 5 months ago by floitsch
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, zra, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Reupload after revert #

Patch Set 3 : Allow remove on unlinked entry and fix nits. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -36 lines) Patch
M pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/builtin.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/core_patch.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/lib/regexp_patch.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/interceptors.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/native_typed_data.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/async/async.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/core.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/internal/internal.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/internal/internal_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A sdk/lib/internal/linked_list.dart View 1 2 1 chunk +126 lines, -0 lines 0 comments Download
M sdk/lib/io/io.dart View 1 chunk +1 line, -8 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/typed_data/typed_data.dart View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
A tests/corelib_2/reg_exp_cache_test.dart View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/svg_dart2js.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
floitsch
This will make it easier to deprecate LinkedList and DoubleLinkedQueue. See https://codereview.chromium.org/2930713003 for the actual ...
3 years, 5 months ago (2017-07-06 15:11:15 UTC) #2
Lasse Reichstein Nielsen
lgtm
3 years, 5 months ago (2017-07-10 09:25:50 UTC) #3
floitsch
Committed patchset #1 (id:1) manually as fe17b5b2bc24454dd2f596d8ce6e2e7661e87f10 (presubmit successful).
3 years, 5 months ago (2017-07-10 12:09:33 UTC) #5
floitsch
PTAL.
3 years, 5 months ago (2017-07-10 14:53:18 UTC) #7
Lasse Reichstein Nielsen
lgtm
3 years, 5 months ago (2017-07-11 07:55:13 UTC) #8
floitsch
3 years, 4 months ago (2017-07-28 19:14:18 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
ee46026671eaec2dca3baa35a87db836ef45154f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698