Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: pkg/compiler/lib/src/native/enqueue.dart

Issue 2975433002: Assert that we don't mix K and J elements (Closed)
Patch Set: Updated cf. comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/native/behavior.dart ('k') | pkg/compiler/lib/src/native/resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/native/enqueue.dart
diff --git a/pkg/compiler/lib/src/native/enqueue.dart b/pkg/compiler/lib/src/native/enqueue.dart
index aefb3d2840230454911c7642cd9d3184c1b77086..5ecffa995c4357523ed354eba3d167858f0f556e 100644
--- a/pkg/compiler/lib/src/native/enqueue.dart
+++ b/pkg/compiler/lib/src/native/enqueue.dart
@@ -203,6 +203,8 @@ class NativeResolutionEnqueuer extends NativeEnqueuerBase {
Iterable<ClassEntity> get registeredClassesForTesting => _registeredClasses;
+ Iterable<ClassEntity> get liveNativeClasses => _registeredClasses;
+
void _registerBackendUse(FunctionEntity element) {
_backendUsageBuilder.registerBackendFunctionUse(element);
_backendUsageBuilder.registerGlobalFunctionDependency(element);
@@ -229,7 +231,7 @@ class NativeResolutionEnqueuer extends NativeEnqueuerBase {
class NativeCodegenEnqueuer extends NativeEnqueuerBase {
final CodeEmitterTask _emitter;
- final NativeResolutionEnqueuer _resolutionEnqueuer;
+ final Iterable<ClassEntity> _nativeClasses;
final NativeData _nativeData;
final Set<ClassEntity> _doneAddSubtypes = new Set<ClassEntity>();
@@ -240,22 +242,21 @@ class NativeCodegenEnqueuer extends NativeEnqueuerBase {
CommonElements commonElements,
DartTypes dartTypes,
this._emitter,
- this._resolutionEnqueuer,
+ this._nativeClasses,
this._nativeData)
: super(options, elementEnvironment, commonElements, dartTypes);
WorldImpact processNativeClasses(Iterable<LibraryEntity> libraries) {
WorldImpactBuilderImpl impactBuilder = new WorldImpactBuilderImpl();
- _unusedClasses.addAll(_resolutionEnqueuer._nativeClasses);
+ _unusedClasses.addAll(_nativeClasses);
if (!enableLiveTypeAnalysis) {
- _registerTypeUses(
- impactBuilder, _resolutionEnqueuer._nativeClasses, 'forced');
+ _registerTypeUses(impactBuilder, _nativeClasses, 'forced');
}
// HACK HACK - add all the resolved classes.
Set<ClassEntity> matchingClasses = new Set<ClassEntity>();
- for (ClassEntity classElement in _resolutionEnqueuer._registeredClasses) {
+ for (ClassEntity classElement in _nativeClasses) {
if (_unusedClasses.contains(classElement)) {
matchingClasses.add(classElement);
}
« no previous file with comments | « pkg/compiler/lib/src/native/behavior.dart ('k') | pkg/compiler/lib/src/native/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698