pkg/compiler/lib/src/js_model/elements.dart - Issue 2975433002: Assert that we don't mix K and J elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_model/elements.dart

Issue 2975433002: Assert that we don't mix K and J elements (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/backend.dart ('K') | « pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart ('k') | pkg/compiler/lib/src/js_model/js_strategy.dart » ('j') | pkg/compiler/lib/src/kernel/native_basic_data.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_model/elements.dart

diff --git a/pkg/compiler/lib/src/js_model/elements.dart b/pkg/compiler/lib/src/js_model/elements.dart

index 4de3aa76f2efbe1a4bd91d5980e511042c546c01..caf5e641404200bd8ae95378832a5a8b609676fc 100644

--- a/pkg/compiler/lib/src/js_model/elements.dart

+++ b/pkg/compiler/lib/src/js_model/elements.dart

@@ -13,6 +13,7 @@ import '../elements/types.dart';

import '../js_backend/backend_usage.dart';

import '../js_backend/interceptor_data.dart';

import '../js_backend/native_data.dart';

+import '../js_backend/runtime_types.dart';

import '../kernel/elements.dart';

import '../kernel/element_map_impl.dart';

import '../native/behavior.dart';

@@ -259,7 +260,7 @@ class TypeConverter implements DartTypeVisitor<DartType, EntityConverter> {

}

-const String jsElementPrefix = 'j';

+const String jsElementPrefix = 'j:';

Siggi Cherem (dart-lang) 2017/07/06 18:14:00 ha - I thought of suggesting this yesterday and di

Johnni Winther 2017/07/07 09:58:28 :)

class JLibrary implements LibraryEntity, IndexedLibrary {

/// Library index used for fast lookup in [JsToFrontendMapImpl].

@@ -493,6 +494,7 @@ class JTypeVariable implements TypeVariableEntity, IndexedTypeVariable {

class JsClosedWorld extends ClosedWorldBase with KernelClosedWorldMixin {

final JsKernelToElementMap elementMap;

+ final RuntimeTypesNeed rtiNeed;

JsClosedWorld(this.elementMap,

{ElementEnvironment elementEnvironment,

@@ -502,7 +504,9 @@ class JsClosedWorld extends ClosedWorldBase with KernelClosedWorldMixin {

NativeData nativeData,

InterceptorData interceptorData,

BackendUsage backendUsage,

+ this.rtiNeed,

Set<ClassEntity> implementedClasses,

+ Iterable<ClassEntity> liveNativeClasses,

Iterable<MemberEntity> liveInstanceMembers,

Iterable<MemberEntity> assignedInstanceMembers,

Set<TypedefElement> allTypedefs,

@@ -519,6 +523,7 @@ class JsClosedWorld extends ClosedWorldBase with KernelClosedWorldMixin {

interceptorData,

backendUsage,

implementedClasses,

+ liveNativeClasses,

liveInstanceMembers,

assignedInstanceMembers,

allTypedefs,