Assert that we don't mix K and J elements

pkg/compiler/lib/src/resolution/resolution_strategy.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.resolution_strategy;
 
 import 'package:front_end/src/fasta/scanner.dart' show Token;
 
 import '../common.dart';
 import '../common_elements.dart';
@@ skipping 14 matching lines @@
 import '../frontend_strategy.dart';
 import '../js_backend/backend.dart';
 import '../js_backend/backend_usage.dart';
 import '../js_backend/interceptor_data.dart';
 import '../js_backend/mirrors_analysis.dart';
 import '../js_backend/mirrors_data.dart';
 import '../js_backend/native_data.dart';
 import '../js_backend/no_such_method_registry.dart';
 import '../js_backend/runtime_types.dart';
 import '../library_loader.dart';
+import '../native/enqueue.dart' show NativeResolutionEnqueuer;
 import '../native/resolver.dart';
 import '../tree/tree.dart' show Node;
 import '../serialization/task.dart';
 import '../patch_parser.dart';
 import '../resolved_uri_translator.dart';
 import '../universe/call_structure.dart';
 import '../universe/use.dart';
 import '../universe/world_builder.dart';
 import '../universe/world_impact.dart';
 import 'no_such_method_resolver.dart';
 
 /// [FrontendStrategy] that loads '.dart' files and creates a resolved element
 /// model using the resolver.
-class ResolutionFrontEndStrategy implements FrontendStrategy {
+class ResolutionFrontEndStrategy extends FrontendStrategyBase {
   final Compiler _compiler;
   final _CompilerElementEnvironment _elementEnvironment;
   final CommonElements commonElements;
 
   AnnotationProcessor _annotationProcessor;
 
   factory ResolutionFrontEndStrategy(Compiler compiler) {
     ElementEnvironment elementEnvironment =
         new _CompilerElementEnvironment(compiler);
     CommonElements commonElements = new CommonElements(elementEnvironment);
@@ skipping 23 matching lines @@
         scriptLoader,
         scriptScanner,
         deserializer,
         patchResolverFunc,
         patchParser,
         environment,
         reporter,
         measurer);
   }
 
-  AnnotationProcessor get annotationProcesser =>
-      _annotationProcessor ??= new _ElementAnnotationProcessor(_compiler);
+  AnnotationProcessor get annotationProcesser => _annotationProcessor ??=
+      new _ElementAnnotationProcessor(_compiler, nativeBasicDataBuilder);
 
   @override
   NativeClassFinder createNativeClassFinder(NativeBasicData nativeBasicData) {
     return new ResolutionNativeClassFinder(
         _compiler.resolution,
         _compiler.reporter,
         elementEnvironment,
         commonElements,
         nativeBasicData);
   }
@@ skipping 12 matching lines @@
   RuntimeTypesNeedBuilder createRuntimeTypesNeedBuilder() {
     return new ResolutionRuntimeTypesNeedBuilderImpl(
         elementEnvironment, dartTypes);
   }
 
   ResolutionWorldBuilder createResolutionWorldBuilder(
       NativeBasicData nativeBasicData,
       NativeDataBuilder nativeDataBuilder,
       InterceptorDataBuilder interceptorDataBuilder,
       BackendUsageBuilder backendUsageBuilder,
+      RuntimeTypesNeedBuilder rtiNeedBuilder,
+      NativeResolutionEnqueuer nativeResolutionEnqueuer,
       SelectorConstraintsStrategy selectorConstraintsStrategy) {
     return new ElementResolutionWorldBuilder(
         _compiler.backend,
         _compiler.resolution,
         nativeBasicData,
         nativeDataBuilder,
         interceptorDataBuilder,
         backendUsageBuilder,
+        rtiNeedBuilder,
+        nativeResolutionEnqueuer,
         selectorConstraintsStrategy);
   }
 
   WorkItemBuilder createResolutionWorkItemBuilder(
       NativeBasicData nativeBasicData,
       NativeDataBuilder nativeDataBuilder,
       ImpactTransformer impactTransformer) {
     return new ResolutionWorkItemBuilder(_compiler.resolution);
   }
 
@@ skipping 522 matching lines @@
   }
 }
 
 /// AST-based logic for processing annotations. These annotations are processed
 /// very early in the compilation pipeline, typically this is before resolution
 /// is complete. Because of that this processor does a lightweight parse of the
 /// annotation (which is restricted to a limited subset of the annotation
 /// syntax), and, once resolution completes, it validates that the parsed
 /// annotations correspond to the correct element.
 class _ElementAnnotationProcessor implements AnnotationProcessor {
-  Compiler _compiler;
+  final Compiler _compiler;
+  final NativeBasicDataBuilder _nativeBasicDataBuilder;
 
-  _ElementAnnotationProcessor(this._compiler);
+  _ElementAnnotationProcessor(this._compiler, this._nativeBasicDataBuilder);
 
   CommonElements get _commonElements => _compiler.resolution.commonElements;
 
   /// Check whether [cls] has a `@Native(...)` annotation, and if so, set its
   /// native name from the annotation.
-  void extractNativeAnnotations(covariant LibraryElement library,
-      NativeBasicDataBuilder nativeBasicDataBuilder) {
+  void extractNativeAnnotations(covariant LibraryElement library) {
     library.forEachLocalMember((Element element) {
       if (element.isClass) {
         EagerAnnotationHandler.checkAnnotation(_compiler, element,
-            new NativeAnnotationHandler(nativeBasicDataBuilder));
+            new NativeAnnotationHandler(_nativeBasicDataBuilder));
       }
     });
   }
 
-  void extractJsInteropAnnotations(covariant LibraryElement library,
-      NativeBasicDataBuilder nativeBasicDataBuilder) {
+  void extractJsInteropAnnotations(covariant LibraryElement library) {
     bool checkJsInteropAnnotation(Element element) {
       return EagerAnnotationHandler.checkAnnotation(
           _compiler, element, const JsInteropAnnotationHandler());
     }
 
     if (checkJsInteropAnnotation(library)) {
-      nativeBasicDataBuilder.markAsJsInteropLibrary(library);
+      _nativeBasicDataBuilder.markAsJsInteropLibrary(library);
     }
     library.forEachLocalMember((Element element) {
       if (element.isClass) {
         ClassElement cls = element;
         if (checkJsInteropAnnotation(element)) {
-          nativeBasicDataBuilder.markAsJsInteropClass(cls);
+          _nativeBasicDataBuilder.markAsJsInteropClass(cls);
         }
       }
     });
   }
 
   void processJsInteropAnnotations(
       NativeBasicData nativeBasicData, NativeDataBuilder nativeDataBuilder) {
     if (_commonElements.jsAnnotationClass == null) return;
 
     ClassElement cls = _commonElements.jsAnnotationClass;
@@ skipping 149 matching lines @@
   @override
   WorkItem createWorkItem(MemberElement element) {
     assert(element.isDeclaration, failedAt(element));
     if (element.isMalformed) return null;
 
     assert(element is AnalyzableElement,
         failedAt(element, 'Element $element is not analyzable.'));
     return _resolution.createWorkItem(element);
   }
 }