Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2975343002: Add libdart PRODUCT targets for Fuchsia's dart_runner (Closed)

Created:
3 years, 5 months ago by zra
Modified:
3 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add libdart PRODUCT targets for Fuchsia's dart_runner R=rmacnak@google.com dart:hello_dart.dartx memory footprint: 6292k -> 5572k Committed: https://github.com/dart-lang/sdk/commit/fa859c507fb6994b7a2b6b08001dfafaf2d89912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -268 lines) Patch
M runtime/BUILD.gn View 3 chunks +69 lines, -7 lines 0 comments Download
M runtime/bin/BUILD.gn View 3 chunks +194 lines, -132 lines 0 comments Download
M runtime/vm/BUILD.gn View 3 chunks +150 lines, -129 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 5 months ago (2017-07-14 22:49:09 UTC) #2
rmacnak
lgtm
3 years, 5 months ago (2017-07-14 23:02:47 UTC) #3
zra
3 years, 5 months ago (2017-07-16 04:43:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fa859c507fb6994b7a2b6b08001dfafaf2d89912 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698