Improvements to incognito and file access metrics for extensions: only record

chrome/browser/extensions/installed_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/installed_loader.h"
 
 #include "base/files/file_path.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 278 matching lines @@
   int platform_app_count = 0;
   int user_script_count = 0;
   int content_pack_count = 0;
   int extension_user_count = 0;
   int extension_external_count = 0;
   int theme_count = 0;
   int page_action_count = 0;
   int browser_action_count = 0;
   int disabled_for_permissions_count = 0;
   int non_webstore_ntp_override_count = 0;
-  int incognito = 0;
-  int not_incognito = 0;
-  int file_access = 0;
-  int not_file_access = 0;
+  int incognito_allowed_count = 0;
+  int incognito_not_allowed_count = 0;
+  int file_access_allowed_count = 0;
+  int file_access_not_allowed_count = 0;
 
   const ExtensionSet& extensions = extension_registry_->enabled_extensions();
   ExtensionActionManager* extension_action_manager =
       ExtensionActionManager::Get(profile);
   for (ExtensionSet::const_iterator iter = extensions.begin();
        iter != extensions.end();
        ++iter) {
     const Extension* extension = *iter;
     Manifest::Location location = extension->location();
     Manifest::Type type = extension->GetType();
@@ skipping 124 matching lines @@
 
     if (ManagedModeInfo::IsContentPack(extension))
       ++content_pack_count;
 
     RecordCreationFlags(extension);
 
     ExtensionService::RecordPermissionMessagesHistogram(
         extension, "Extensions.Permissions_Load");
 
     // For incognito and file access, skip anything that doesn't appear in
-    // settings.
-    if (extension->ShouldDisplayInExtensionSettings()) {
+    // settings. Also, policy-installed (and unpacked of course, checked above)
+    // extensions are boring.
+    if (extension->ShouldDisplayInExtensionSettings() &&
+        !Manifest::IsPolicyLocation(extension->location())) {
       if (extension->can_be_incognito_enabled()) {
         if (util::IsIncognitoEnabled(extension->id(), profile))
-          ++incognito;
+          ++incognito_allowed_count;
         else
-          ++not_incognito;
+          ++incognito_not_allowed_count;
       }
       if (extension->wants_file_access()) {
         if (util::AllowFileAccess(extension->id(), profile))
-          ++file_access;
+          ++file_access_allowed_count;
         else
-          ++not_file_access;
+          ++file_access_not_allowed_count;
       }
     }
   }
 
   const ExtensionSet& disabled_extensions =
       extension_registry_->disabled_extensions();
 
   for (ExtensionSet::const_iterator ex = disabled_extensions.begin();
        ex != disabled_extensions.end();
        ++ex) {
@@ skipping 50 matching lines @@
   UMA_HISTOGRAM_COUNTS_100("Extensions.LoadUserScript", user_script_count);
   UMA_HISTOGRAM_COUNTS_100("Extensions.LoadTheme", theme_count);
   UMA_HISTOGRAM_COUNTS_100("Extensions.LoadPageAction", page_action_count);
   UMA_HISTOGRAM_COUNTS_100("Extensions.LoadBrowserAction",
                            browser_action_count);
   UMA_HISTOGRAM_COUNTS_100("Extensions.LoadContentPack", content_pack_count);
   UMA_HISTOGRAM_COUNTS_100("Extensions.DisabledForPermissions",
                            disabled_for_permissions_count);
   UMA_HISTOGRAM_COUNTS_100("Extensions.NonWebStoreNewTabPageOverrides",
                            non_webstore_ntp_override_count);
-  UMA_HISTOGRAM_COUNTS_100("Extensions.IncognitoAllowed", incognito);
-  UMA_HISTOGRAM_COUNTS_100("Extensions.IncognitoNotAllowed", not_incognito);
-  UMA_HISTOGRAM_COUNTS_100("Extensions.FileAccessAllowed", file_access);
-  UMA_HISTOGRAM_COUNTS_100("Extensions.FileAccessNotAllowed", not_file_access);
+  if (incognito_allowed_count + incognito_not_allowed_count > 0) {
+    UMA_HISTOGRAM_COUNTS_100("Extensions.IncognitoAllowed",
+                             incognito_allowed_count);
+    UMA_HISTOGRAM_COUNTS_100("Extensions.IncognitoNotAllowed",
+                             incognito_not_allowed_count);
+  }
+  if (file_access_allowed_count + file_access_not_allowed_count > 0) {
+    UMA_HISTOGRAM_COUNTS_100("Extensions.FileAccessAllowed",
+                             file_access_allowed_count);
+    UMA_HISTOGRAM_COUNTS_100("Extensions.FileAccessNotAllowed",
+                             file_access_not_allowed_count);
+  }
 }
 
 int InstalledLoader::GetCreationFlags(const ExtensionInfo* info) {
   int flags = extension_prefs_->GetCreationFlags(info->extension_id);
   if (!Manifest::IsUnpackedLocation(info->extension_location))
     flags |= Extension::REQUIRE_KEY;
   if (extension_prefs_->AllowFileAccess(info->extension_id))
     flags |= Extension::ALLOW_FILE_ACCESS;
   return flags;
 }
 
 }  // namespace extensions