Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2975323002: Renamed some scoping classes to make their usage clearer. (Closed)

Created:
3 years, 5 months ago by Emily Fortuna
Modified:
3 years, 5 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Renamed some scoping classes to make their usage clearer. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/45c57c885928c040a9789a985929579868470641

Patch Set 1 : . #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -86 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 15 chunks +30 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure.dart View 1 4 chunks +12 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure_visitors.dart View 1 5 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_model/locals.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 11 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 10 chunks +12 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/loop_handler.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Emily Fortuna
3 years, 5 months ago (2017-07-14 20:37:29 UTC) #2
sra1
lgtm https://codereview.chromium.org/2975323002/diff/20001/pkg/compiler/lib/src/closure.dart File pkg/compiler/lib/src/closure.dart (right): https://codereview.chromium.org/2975323002/diff/20001/pkg/compiler/lib/src/closure.dart#newcode109 pkg/compiler/lib/src/closure.dart:109: class ScopeInClosure extends ScopeInfo { Maybe CapturedScope is ...
3 years, 5 months ago (2017-07-14 20:57:39 UTC) #4
Emily Fortuna
3 years, 5 months ago (2017-07-15 00:03:41 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
45c57c885928c040a9789a985929579868470641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698